SeedChangeRequests: name the sibling seeded requests the way the code spells them - #458
Merged
Merged
Conversation
Both comments pointed at a seeded request as SEED006 and SEED008, which is how
the references were written before they were generated. The rows are unchanged —
Reference(n) produces exactly CYPMD_KS4June_SEED{n:000} — so the comments were
accurate, but a reader had to map between two names for the same thing, and the
obvious reading was that they referred to something the code no longer creates.
Refs #457
ajs-uk-dev
approved these changes
Sep 17, 2026
paulc1983
approved these changes
Sep 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two comments in
SeedChangeRequests.cspointed at a seeded request asSEED006andSEED008, which is how the references were written before they were generated:The comments were accurate — Reference(n) produces exactly CYPMD_KS4June_SEED{n:000}, so
Reference(7) is CYPMD_KS4June_SEED007 and the seeded data is unchanged. But a reader had to
map between two names for the same thing to see which row was being pointed at, and the obvious
reading was that the comment referred to something the code no longer creates.
They now name the sibling row the way the line beside them does.
Comments only. No behaviour change, and nothing about what is seeded changed.
Testing
011, same statuses, same pupils
Closes #457