Skip to content

SeedChangeRequests: name the sibling seeded requests the way the code spells them - #458

Merged
dfe-lance merged 1 commit into
mainfrom
457-seed-reference-comments
Sep 17, 2026
Merged

dfe-lance merged 1 commit into
mainfrom
457-seed-reference-comments

Conversation

@dfe-lance

Copy link
Copy Markdown
Contributor

Two comments in SeedChangeRequests.cs pointed at a seeded request as SEED006 and
SEED008, which is how the references were written before they were generated:

(Reference: Reference(7), Status: RequestStatus.ReadyToSubmit, Pupil: p[5]), // duplicate of SEED006
(Reference: Reference(9), Status: RequestStatus.ReadyToSubmit, Pupil: p[6]), // duplicate of already-submitted SEED008

The comments were accurate — Reference(n) produces exactly CYPMD_KS4June_SEED{n:000}, so
Reference(7) is CYPMD_KS4June_SEED007 and the seeded data is unchanged. But a reader had to
map between two names for the same thing to see which row was being pointed at, and the obvious
reading was that the comment referred to something the code no longer creates.

They now name the sibling row the way the line beside them does.

Comments only. No behaviour change, and nothing about what is seeded changed.

Testing

  • Seeded rows read back from the database after a rebuild: still CYPMD_KS4June_SEED001 to
    011, same statuses, same pupils
  • Unit 5289 passed, integration 809 passed, full E2E 206 passed
  • Full Release build of the solution clean, no warnings on changed lines

Closes #457

Both comments pointed at a seeded request as SEED006 and SEED008, which is how
the references were written before they were generated. The rows are unchanged —
Reference(n) produces exactly CYPMD_KS4June_SEED{n:000} — so the comments were
accurate, but a reader had to map between two names for the same thing, and the
obvious reading was that they referred to something the code no longer creates.

Refs #457
@dfe-lance
dfe-lance merged commit 3583347 into main Sep 17, 2026
8 checks passed
@dfe-lance
dfe-lance deleted the 457-seed-reference-comments branch September 17, 2026 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

SeedChangeRequests: two comments name seeded requests in a spelling the code no longer uses

3 participants