feat: 1762 - firewall and peering#344
Open
StuwiiDev wants to merge 7 commits into
Open
Conversation
StuwiiDev
force-pushed
the
feat/1762/firewall
branch
2 times, most recently
from
8f8db88 to
305e0cf
Compare
StuwiiDev
force-pushed
the
feat/1762/firewall
branch
from
15779ac to
ff332df
Compare
StuwiiDev
force-pushed
the
feat/1762/firewall
branch
2 times, most recently
from
0c78c32 to
5b798a3
Compare
also sets up a public IP
…puts to use new egress
…warded traffic in VNets
StuwiiDev
force-pushed
the
feat/1762/firewall
branch
from
5b798a3 to
59db23b
Compare
|
|
jtaylor100
reviewed
Jun 3, 2026
Comment on lines
+76
to
+86
| { | ||
| // Basic-tier ACR serves image layers from shared Azure Storage; narrowing | ||
| // this requires upgrading ACR to Premium with dedicated data endpoints. | ||
| name: 'acr-blob-allow' | ||
| #disable-next-line no-hardcoded-env-urls | ||
| fqdn: '*.blob.core.windows.net' | ||
| } | ||
| { | ||
| name: 'kv-allow' | ||
| fqdn: keyVaultEndpoint | ||
| } |
Collaborator
There was a problem hiding this comment.
Won't these be covered by the private endpoints?
| } | ||
| ] | ||
|
|
||
| resource firewallVirtualNetwork 'Microsoft.Network/virtualNetworks@2024-05-01' = { |
Collaborator
There was a problem hiding this comment.
Does it need to be in a separate virtual network to be peered, or just a different subnet in the same network? I assumed the latter, but not sure if you've hit any technical bump
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add a firewall, route table and peering so traffic in the CAE VNET can only pass out through it.
Changes
Validation