Skip to content

feat: add readable Unicode previews for properties files - #346

Closed
xianyuli wants to merge 1 commit into
DEEIX-AI:devfrom
xianyuli:codex/properties-unicode-preview
Closed

xianyuli wants to merge 1 commit into
DEEIX-AI:devfrom
xianyuli:codex/properties-unicode-preview

Conversation

@xianyuli

Copy link
Copy Markdown

Summary

Add readable Unicode previews for Java .properties files through Winc's existing Code, Split, and Preview controls.

For example, the source text greeting=\u4F60\u597D is displayed as greeting=你好 in the preview.

  • Show a live, read-only preview beside the editable source or across the full editor pane.
  • Support mouse selection, Copy, Select All, keyboard navigation, and context-menu copying of decoded text.
  • Remember the selected mode independently for Properties files.
  • Preserve source text, encoding, and undo history across view changes. Keep save-time cleanup and formatting available for writable source documents.

Regression coverage includes wrapped and narrow-pane transitions, Unicode and multiline selection, long-line copying, save protection for image and workbook previews, hex reopening, and large-file reloads.

Change type

  • Feature

Verification

  • cargo fmt --all --check
  • cargo clippy --workspace --all-targets -- -D warnings
  • cargo xtask test --all
  • RUSTDOCFLAGS="-D warnings" cargo doc --workspace --no-deps
  • cargo xtask bench 3

Automated checks passed on macOS: 2,867 tests passed, with 188 ignored. Linux and Windows validation is left to CI.

The repository benchmarks passed. Startup for large.rs was 116.4 ms, scroll p95 was 0.8 ms, and Markdown preview scroll p95 was 1.7 ms, all within the existing budgets.

Screenshots

Code

Code

Split

Split

Preview selection

Preview selection

Checklist

  • The change is focused and does not include unrelated refactoring or formatting.
  • Tests cover the new behavior and related regression cases.
  • New interface text is added in both English and Simplified Chinese.
  • Startup time, memory use, and large files stay within the repository's benchmark budgets.
  • I have read and agree to the Contributor License Agreement.

Show decoded Unicode escapes in full and split previews, with selection,
copying, keyboard navigation, and independent mode preferences.

Preserve source text and encoding through preview transitions and saving.
Keep save-time cleanup and formatting available for writable sources, and
cover read-only files, hex views, reloads, and preview interactions.
@github-actions

github-actions Bot commented Nov 21, 2026 •

Copy link
Copy Markdown

All commit authors have signed the Contributor License Agreement. Thank you!

@xianyuli

Copy link
Copy Markdown
Author

I have read the CLA Document and I hereby sign the CLA

@xianyuli xianyuli closed this Nov 21, 2026
@xianyuli
xianyuli deleted the codex/properties-unicode-preview branch November 21, 2026 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant