Repository navigation
Conversation
Recheck local status while the Git view is visible and focused, and refresh on focus recovery even when the filesystem watcher is live. Cover missed notifications, focus recovery, repeated writes, and replacement saves with regression tests.
Clip editor content and hit targets when a maximized terminal hides the editor or a narrow pane cannot fit its fixed-width controls. Keep preview shadows, selection controls, notices, and conflict cards in their areas. Add pixel and hit-target regressions for zero-sized and narrow panes, light and dark themes, and fractional display scales.
Composite filename fades over the current repository card and row state instead of the plain sidebar background. Reuse the same name layout and fade for other repositories, including hovered rows. Compare rendered rows across themes, display scales, sidebar widths, and checkbox or staging modes.
|
All commit authors have signed the Contributor License Agreement. Thank you! |
Author
|
I have read the CLA Document and I hereby sign the CLA |
Keep the same clipping and hit bounds at the pane drawing entry, leaving the editor content function unchanged. This also preserves the source fixture used by the existing smooth sticky-scroll regression.
ventupx
marked this pull request as ready for review
November 21, 2026 07:35
Apply the selected layout to every repository in the Git sidebar, including compact directories, independent folds, and staging groups. Discard obsolete row animations when switching layouts. Keep the sidebar splitter draggable when a filename is expanded and finish filename transitions during resizing so they cannot leave text over the editor or terminal. Add Windows-capable menu, tree, dragging, and pixel regression tests.
Ignore cached file-tree overflow hit regions outside the file view so they cannot intercept the Git sidebar splitter or the adjacent editor. Seed stale hit regions in the resizing regression to cover every host. Move the periodic Git status recheck into its own module without changing its behavior, keeping the parent module below the source line limit.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix Git sidebar inconsistencies when viewing multiple repositories, resizing the sidebar, or editing files with external tools. Selecting tree mode now applies to every repository, and expanded filenames no longer prevent divider dragging or leave text over the editor or terminal.
Regression tests cover menu selection through actual hit targets, tree/list switching, directory folds, staging groups, divider dragging with expanded filenames, and pixel comparisons that detect residual text during resizing in light/dark themes and tree/list layouts. The earlier refresh, pane-containment, and filename-fade regression coverage is retained.
Change type
Verification
Latest commit:
d6f403d3e178a1a82e92c39995c6254c7b91a2aa.Full three-platform CI run: all nine jobs passed for this commit.
cargo fmt --all --checkcargo clippy --workspace --all-targets --locked -- -D warningson Windows, Linux, and macOSRUSTDOCFLAGS="-D warnings" cargo doc --workspace --no-deps --lockedon Windows, Linux, and macOScargo test --workspace --locked --no-fail-faston Windows, Linux, and macOS--versionsmoke checkThe native Windows full suite was also rerun from an LF source export of this exact commit, matching the CI checkout settings: 2,186 passed, 0 failed, 106 ignored. The application suite includes 897 passed, 0 failed, 96 ignored. Local validation used Rust 1.99.1 and
--test-threads=4, with isolated application-data directories.The resizing regression covers stale filename hit regions retained by a hidden file tree, in addition to the light/dark, tree/list, and residual-pixel cases. Periodic Git status rechecks now live in a separate module without changing their behavior;
git.rshas 1,477 lines and passes the 1,500-line source limit on Linux and macOS.Upstream PR status: CLA passed. The upstream CI and Commit messages workflows for this commit are awaiting maintainer approval (
action_required). The successful run linked above is in the fork and does not replace the upstream required checks.Screenshots
Before: filename remnants over the terminal during sidebar resizing
Reporter-provided screenshot:
Before: tree mode selected, but other repositories remain flat
Reporter-provided screenshot:
After: non-current repository follows tree mode
Windows offscreen regression fixture rendered from the latest commit:
For the resizing issue, pixel regression tests first expand the filename, then begin a divider drag during its retraction. They verify that the editor pixels return to the unobstructed baseline during dragging and that the sidebar width still changes. The test fails with the former behavior.
Earlier reported rendering problems covered by this PR
Git log controls overlapping the sidebar toolbar:
Light-theme filename fades using the wrong background:
Images are stored on a separate attachment branch in the fork and add no binary files to the code diff.
Checklist