fix: remove stale user settings cache - #592
Open
onedotmint wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes stale conversation user settings after an update by removing the process-local user settings cache and reading the affected settings directly from the repository.
This ensures changes to:
chat.reasoning_content_passbackchat.context_compact_autochat.file_modeare observed immediately instead of potentially remaining stale for up to 10 minutes.
Adds regression coverage for updating these settings through
usersettings.Service.PatchSettingsand reading the updated values through the conversation service.Fixes #589
Change type
Affected areas
Verification
go -C backend test ./...pnpm checkpnpm testpnpm buildgit diff --checkNot run; reason:
Screenshots, API examples, or logs
Not applicable; this change has no UI changes or API contract changes.
Configuration, migration, and compatibility notes
No configuration changes, database migrations, or API contract changes are required.
The process-local user settings cache has been removed. This trades cache hits for direct indexed user-setting repository reads during message handling so updated settings are observed immediately, including in multi-node deployments using shared persistence.
Documentation
Security and privacy
Checklist
.pycfiles,.envfiles, and local storage data are not committed.