Skip to content

Conversation

@hbirth
Copy link
Collaborator

@hbirth hbirth commented Dec 22, 2025

No description provided.

no functional change

Signed-off-by: Horst Birthelmer <hbirthelmer@ddn.com>
Signed-off-by: Horst Birthelmer <hbirthelmer@ddn.com>
@hbirth hbirth requested review from bsbernd and yongzech December 22, 2025 09:17
@hbirth hbirth marked this pull request as draft December 23, 2025 21:25
…) returns

some other error than ENOSYS. The returned error got overwritten.

Signed-off-by: Horst Birthelmer <hbirthelmer@ddn.com>
@hbirth hbirth requested a review from cding-ddn January 3, 2026 13:10
@hbirth hbirth changed the title small overall improvements and error handling for open+getattr improve error handling in compounds and open+getattr Jan 3, 2026
@hbirth hbirth marked this pull request as ready for review January 3, 2026 13:10
cding-ddn
cding-ddn previously approved these changes Jan 4, 2026
Copy link
Collaborator

@cding-ddn cding-ddn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bsbernd
Copy link
Collaborator

bsbernd commented Jan 8, 2026

Maybe we should update with the version for upstream?

@hbirth
Copy link
Collaborator Author

hbirth commented Jan 8, 2026

Maybe we should update with the version for upstream?

That is actually a good idea

@hbirth hbirth changed the title improve error handling in compounds and open+getattr simplify compound commands and improve error handling in compounds and open+getattr Jan 8, 2026
@hbirth hbirth requested a review from cding-ddn January 8, 2026 19:39
@hbirth hbirth force-pushed the redfs-ubuntu-noble-6.8.0-58.60 branch from c6f881e to b74783d Compare January 8, 2026 19:45
Simplify fuse_compound_req to hold only the pointers
to the added fuse args and the request housekeeping.

Simplify open+getattr call by using helper functions
to fill out the fuse request parameters

Signed-off-by: Horst Birthelmer <hbirthelmer@ddn.com>
@hbirth hbirth force-pushed the redfs-ubuntu-noble-6.8.0-58.60 branch from b74783d to be508b6 Compare January 8, 2026 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants