Prefix update to allow specifying if Prefix should be used on the different Query By parameters#293
Open
brainded wants to merge 2 commits intoDAXGRID:masterfrom
Open
Prefix update to allow specifying if Prefix should be used on the different Query By parameters#293brainded wants to merge 2 commits intoDAXGRID:masterfrom
brainded wants to merge 2 commits intoDAXGRID:masterfrom
Conversation
Member
|
Hi @brainded, I'll take a look at it, this week. // Rune |
Member
|
Hi @brainded I looked at the change, normally I would not like breaking changes, but I rather we just change it to a list of // Rune |
Contributor
Author
|
@runeanielsen I will refactor to use that suggestion soon! Thanks for the feedback! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prefix currently is only a single Boolean but can support the setting per Query By. This change seeks to limit disturbing existing clients but expanding the capability to allow the full functionality.
I did not mark the existing Prefix as obsolete but I can if the community thinks its best.