Skip to content

feat(tools-core): land the flight_ground Rust slice of #4466 - #4526

Merged
dieterolson merged 1 commit into
mainfrom
feat/tools-core-flight-ground-slice
Aug 18, 2026
Merged

feat(tools-core): land the flight_ground Rust slice of #4466#4526
dieterolson merged 1 commit into
mainfrom
feat/tools-core-flight-ground-slice

Conversation

@dieterolson

Copy link
Copy Markdown
Collaborator

39 new files under rust_core/tools-core/src/flight_ground/: bounce, impact, reference and surface runtimes, canonical and strict JSON, the v1 request/result wire, resource limits, result geometry and validation, plus the ground_reference benchmark and the Rust, Python and Node conformance suites.

This slice is genuinely independent — unlike the Python areas it depends on no other slice, which is why it goes now while ui/pyqt6 waits on #4524.

On the WASM files, precisely

It includes wasm.rs, wasm_reference.rs, wasm_request.rs and wasm_result.rs — the kernel side of the Phase 7 parity work still open under #4103.

Worth being exact about what this is not: it lands the crate only. It does not add a Pages deploy workflow, and it does not swap the hand-written TypeScript mirrors. Both belong to #4103 Phase 7, which the handoff explicitly says not to improvise elsewhere. So this does not close Phase 7.

Purely additive against main

src/lib.rs gains pyo3 registrations for PyFlightGroundRequest, PyFlightGroundResult and five py_* entry points. Both it and Cargo.toml are additive — lib.rs is +25/−0, Cargo.toml promotes serde_json from dev-dependencies and registers the new bench.

Neither reverts anything, which is the failure mode every earlier slice in this series had to guard against.

Verification

  • cargo check builds clean
  • 191 tools-core tests pass across nine binaries
  • cargo fmt --check clean
  • cargo clippy --all-targets clean
  • no Python or TypeScript source changes

Part of epic #4103.

🤖 Generated with Claude Code

39 new files under `rust_core/tools-core/src/flight_ground/`: the bounce,
impact, reference and surface runtimes, canonical and strict JSON, the v1
request/result wire, resource limits, result geometry and validation, plus the
`ground_reference` benchmark and the Rust, Python and Node conformance suites.

This slice is genuinely independent — unlike the Python areas it depends on no
other slice, which is why it goes now while `ui/pyqt6` waits on #4524.

It includes the WASM boundary (`wasm.rs`, `wasm_reference.rs`, `wasm_request.rs`,
`wasm_result.rs`). That is the kernel side of the Phase 7 parity work still open
under #4103, and worth being precise about: this lands the crate only. It does
not add a Pages deploy workflow and does not swap the hand-written TypeScript
mirrors, both of which #4103 Phase 7 owns and the handoff explicitly says not to
improvise elsewhere.

`src/lib.rs` gains the pyo3 registrations for `PyFlightGroundRequest`,
`PyFlightGroundResult` and the five `py_*` entry points. Both it and
`Cargo.toml` are purely additive against main — `lib.rs` is +25/-0, and
`Cargo.toml` promotes `serde_json` from dev-dependencies and registers the new
bench — so neither reverts anything, which is the failure mode every earlier
slice had to guard against.

Verified: `cargo check` builds, 191 `tools-core` tests pass across nine
binaries, `cargo fmt --check` and `cargo clippy --all-targets` are clean. No
Python or TypeScript source changes.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, add credits to your account and enable them for code reviews in your settings.

@dieterolson
dieterolson enabled auto-merge (squash) August 18, 2026 07:11
@dieterolson
dieterolson merged commit 5f5a653 into main Aug 18, 2026
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant