feat(tools-core): land the flight_ground Rust slice of #4466 - #4526
Merged
Conversation
39 new files under `rust_core/tools-core/src/flight_ground/`: the bounce, impact, reference and surface runtimes, canonical and strict JSON, the v1 request/result wire, resource limits, result geometry and validation, plus the `ground_reference` benchmark and the Rust, Python and Node conformance suites. This slice is genuinely independent — unlike the Python areas it depends on no other slice, which is why it goes now while `ui/pyqt6` waits on #4524. It includes the WASM boundary (`wasm.rs`, `wasm_reference.rs`, `wasm_request.rs`, `wasm_result.rs`). That is the kernel side of the Phase 7 parity work still open under #4103, and worth being precise about: this lands the crate only. It does not add a Pages deploy workflow and does not swap the hand-written TypeScript mirrors, both of which #4103 Phase 7 owns and the handoff explicitly says not to improvise elsewhere. `src/lib.rs` gains the pyo3 registrations for `PyFlightGroundRequest`, `PyFlightGroundResult` and the five `py_*` entry points. Both it and `Cargo.toml` are purely additive against main — `lib.rs` is +25/-0, and `Cargo.toml` promotes `serde_json` from dev-dependencies and registers the new bench — so neither reverts anything, which is the failure mode every earlier slice had to guard against. Verified: `cargo check` builds, 191 `tools-core` tests pass across nine binaries, `cargo fmt --check` and `cargo clippy --all-targets` are clean. No Python or TypeScript source changes. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
dieterolson
enabled auto-merge (squash)
August 18, 2026 07:11
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
39 new files under
rust_core/tools-core/src/flight_ground/: bounce, impact, reference and surface runtimes, canonical and strict JSON, the v1 request/result wire, resource limits, result geometry and validation, plus theground_referencebenchmark and the Rust, Python and Node conformance suites.This slice is genuinely independent — unlike the Python areas it depends on no other slice, which is why it goes now while
ui/pyqt6waits on #4524.On the WASM files, precisely
It includes
wasm.rs,wasm_reference.rs,wasm_request.rsandwasm_result.rs— the kernel side of the Phase 7 parity work still open under #4103.Worth being exact about what this is not: it lands the crate only. It does not add a Pages deploy workflow, and it does not swap the hand-written TypeScript mirrors. Both belong to #4103 Phase 7, which the handoff explicitly says not to improvise elsewhere. So this does not close Phase 7.
Purely additive against main
src/lib.rsgains pyo3 registrations forPyFlightGroundRequest,PyFlightGroundResultand fivepy_*entry points. Both it andCargo.tomlare additive —lib.rsis +25/−0,Cargo.tomlpromotesserde_jsonfrom dev-dependencies and registers the new bench.Neither reverts anything, which is the failure mode every earlier slice in this series had to guard against.
Verification
cargo checkbuilds cleantools-coretests pass across nine binariescargo fmt --checkcleancargo clippy --all-targetscleanPart of epic #4103.
🤖 Generated with Claude Code