fix(rate-of-closure): repair three variation modules that are unimportable on main

[dieterolson]

main is currently broken. Three modules cannot be imported:

ImportError: cannot import name 'to_ground_model_result'
from 'shared.python.swing_sim.ground'

Affected: regional_ground_study_adapter, regional_ground_variation, regional_ground_target_projection.

Two of my own PRs combined to cause it

• feat(swing-sim): land the ground skid/roll/bounce module as a standalone slice of #4466 #4517 removed to_ground_model_result from the ground package's eager exports — correctly. That package's own test_unqualified_compatibility_adapter_is_not_public requires the explicitly unqualified compatibility adapter to stay private, and it is absent from both __all__ and the lazy-import map.
• feat(rate-of-closure): land the variation slice of #4466 #4520 then landed a consumer importing it from the package path.

Neither PR's tests imported the adapter module, so both were green while three modules could not load at all.

The fix

The import now names the owning module, shared.python.swing_sim.ground.result_adapter, which does export it. That keeps the package contract intact — the unqualified adapter is still not package-public — while making the unqualified dependency explicit at the call site, which is the honest thing for a compatibility path. The ground contract test still passes, so nothing #4517 established is weakened.

The check that was missing

tests/rate_of_closure/test_variation_module_importability.py imports every module in the package.

A suite can be entirely green while a module in it is unreachable, and no existing gate covered that. This also catches the neighbouring cases: a symbol dropped from a package's __all__, a rename, a new circular import.

Verified by reverting the one-line fix: 3 failed, 35 passed.

Please prioritise — every PR branched from current main inherits the breakage.

🤖 Generated with Claude Code

[chatgpt-codex-connector]

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, add credits to your account and enable them for code reviews in your settings.