feat(rate): add bounded club explorer camera - #4444
Draft
d-sorgcodexagent[bot] wants to merge 6 commits into
Draft
feat(rate): add bounded club explorer camera#4444d-sorgcodexagent[bot] wants to merge 6 commits into
d-sorgcodexagent[bot] wants to merge 6 commits into
Conversation
29 tasks
This was referenced Aug 14, 2026
dieterolson
pushed a commit
that referenced
this pull request
Aug 14, 2026
The web build was broken and two React tests failed once the whole family was integrated. Both are genuine cross-slice defects that no individual PR could expose, because each slice only ever ran against its own parent. 1. `npm run build` (tsc) failed, which is why "Rate web production Worker E2E" could not even start its preview server. #4431 made `executionMetadata` required on `VariationExecutionRequest`/`VariationExecutionResult`, but four test fixtures introduced by the #4444 chain construct those objects without it. Supplied it the way the already-updated fixtures in the same file do -- from the request under test, which also satisfies `validateResult`'s request/result metadata equality check. For the two unsupported-flight-model cases the request is now spread from `jointRequest()` with only the plan overridden; `validateExecutionRequest` runs `validatePlan` before the metadata comparison, so the assertion still exercises the flight-model rejection it was written for. 2. A real behavioural regression. `importPlan` sets the plan, clears results, then reports provenance -- either "resolves against the current variable registry ... not evidence of historical reproducibility" for a raw plan, or "Execution sidecar verified against the current registry" for a signed document. The #4444 chain added an effect that calls `invalidateResults` on every configuration-identity change. Changing the plan changes that identity, so the effect ran after commit and overwrote the provenance message with the generic "Ready: configuration changed; run again." The user was silently denied the one message that tells them a loaded plan was re-resolved against today's registry rather than its recorded one. `invalidateResults` now announces only a discard that actually happened, decided from refs so the callback identity stays stable and the effect cannot re-trigger itself. Nothing else references that string, and the invalidation tests assert visual state and heading removal rather than status text, so they are unaffected -- they invalidate with results present, where the message still appears. Verified in the web workspace: tsc clean, eslint clean (--max-warnings 0), vite build succeeds, and vitest is 1084/1084 across 126 files (was 1082/1084).
This was referenced Aug 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Scientific and interaction contract
Evidence
Artifacts remain diagnostic, not approved goldens. Portable mesh archive identity, formal AT validation, approved baselines, and remaining #4433 tabs stay open.
Depends on #4443. Advances #4433; does not close it.