Skip to content

feat(rate-of-closure): add camera tracking and snap views - #4298

Closed
d-sorgcodexagent[bot] wants to merge 48 commits into
feat/4199-wind-workflowfrom
feat/4284-camera-snap-tracking
Closed

feat(rate-of-closure): add camera tracking and snap views#4298
d-sorgcodexagent[bot] wants to merge 48 commits into
feat/4199-wind-workflowfrom
feat/4284-camera-snap-tracking

Conversation

@d-sorgcodexagent

@d-sorgcodexagent d-sorgcodexagent Bot commented Aug 9, 2026

Copy link
Copy Markdown
Contributor

Summary

  • add shared Python/TypeScript camera state with canonical isometric, face-on (explicit side), down-the-line, and overhead views
  • add bounded opt-in clubhead/ball tracking, preserved zoom, manual-orbit suspension, Auto Fit, and Recenter across Tools PyQt and React viewports
  • add deterministic previous/next solver-frame stepping and real-browser coverage for playback/camera interaction combinations
  • use immutable campaign evidence_commit_sha metadata rather than an impossible self-referential mutable PR-head field
  • normally propagate the exact repaired flight-to-ground stack through feat(flight-ground): qualify physical transfer state #4288 while preserving the unchanged feat/4199-wind-workflow base
  • repair the complete hosted MyPy delta without changing runtime values, wire bytes, coordinate transforms, physics, or camera behavior

Current exact evidence

  • current exact PR head: 57942e64744a199e4fd7d604fe2eeb9faddd062a
  • composed-stack merge commit: a51e49e4d2e7f5b1985c802f8290ea7649e7927e
  • merge parents, in order: original camera child 9ffd8d280c77977a41e93bd0caef9678d1c231b6; repaired feat(flight-ground): qualify physical transfer state #4288 parent 108a841b1378c992defd3c7b7ee263d41a6c8b24
  • immutable original camera implementation evidence remains 2095e748ddca2d7036bbd49a731528f5634daff9
  • complete composed Python gate: 1,738 passed with two explicit optional build123d skips; installed tools_core parity executed
  • complete React gate: 110 files / 670 tests; TypeScript, zero-warning ESLint, and 194-module production build passed
  • browser camera gate: four Playwright cases across desktop and constrained 2x-DPR viewport
  • Rust: all 137 tools-core tests, formatting, and warning-denied Clippy passed
  • hosted-delta repair: the exact pinned MyPy 1.13 command passes all 33 changed production files; 79 focused ground/transfer/flight tests and Ruff/format pass
  • Bandit, campaign manifest, documentation, module/500-line, assertion, secrets, conflict-marker, and diff gates passed
  • two independent exact-tree reviews found no findings: the composed stack and the hosted-delta typing repair were both reviewed before publication

Remaining gates

This remains a draft feature-stack PR. Fresh protected current-head CI and required review are required after the hosted-delta repair; the obsolete failed job 93503197807 on head a51e49e4d2e7f5b1985c802f8290ea7649e7927e will not be retried. Native rendered/font QA and UpstreamDrift consumer parity against an immutable protected Tools pin are also still required. Camera preference persistence remains tracked by parent workspace epic #4218 and is not claimed here. No branch was rebased, retargeted, rewritten, or force-pushed.

Relates to #4284 and #4218.

…8-ground-contract

# Conflicts:
#	AGENT_HANDOFF.md
#	SPEC.md
#	docs/development/RATE_OF_CLOSURE_CAMPAIGN_HANDOFF.md
#	src/rate_of_closure/AGENT_HANDOFF.md
# Conflicts:
#	SPEC.md
#	docs/development/RATE_OF_CLOSURE_CAMPAIGN_HANDOFF.md
…9-flight-ground-transfer

# Conflicts:
#	AGENT_HANDOFF.md
#	SPEC.md
#	docs/development/RATE_OF_CLOSURE_CAMPAIGN_HANDOFF.md
#	src/rate_of_closure/AGENT_HANDOFF.md
#	src/shared/python/swing_sim/flight/tests/test_contract_api.py
# Conflicts:
#	AGENT_HANDOFF.md
#	SPEC.md
#	docs/development/RATE_OF_CLOSURE_CAMPAIGN_HANDOFF.md
#	src/rate_of_closure/AGENT_HANDOFF.md
# Conflicts:
#	AGENT_HANDOFF.md
#	SPEC.md
#	docs/development/RATE_OF_CLOSURE_CAMPAIGN_HANDOFF.md
#	src/rate_of_closure/AGENT_HANDOFF.md
# Conflicts:
#	SPEC.md
#	docs/development/RATE_OF_CLOSURE_CAMPAIGN_HANDOFF.md
codex-scheduled added 21 commits August 10, 2026 14:40
# Conflicts:
#	AGENT_HANDOFF.md
#	SPEC.md
#	docs/development/RATE_OF_CLOSURE_CAMPAIGN_HANDOFF.md
#	src/rate_of_closure/AGENT_HANDOFF.md
…7-capability-observer

# Conflicts:
#	AGENT_HANDOFF.md
#	SPEC.md
#	src/rate_of_closure/AGENT_HANDOFF.md
…8-ground-contract

# Conflicts:
#	AGENT_HANDOFF.md
#	SPEC.md
#	docs/release/rate_of_closure_campaign.v1.json
#	src/rate_of_closure/AGENT_HANDOFF.md
…9-flight-ground-transfer

# Conflicts:
#	SPEC.md
#	docs/release/rate_of_closure_campaign.v1.json
@d-sorgcodexagent
d-sorgcodexagent Bot marked this pull request as ready for review August 12, 2026 00:27
@dieterolson

Copy link
Copy Markdown
Collaborator

Consolidated into #4410. Closing to eliminate CI runner load.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant