feat(rate_of_closure): add exact 3D D-plane overlays - #4202
Closed
dieterolson wants to merge 7 commits into
Closed
Conversation
This was referenced Aug 6, 2026
Contributor
Exact-head D-plane type-gate repairPublished head:
The branch remains draft. Current-head protected CI, review, and parent-first dependency order remain release gates. This does not claim completion of #4189. |
Collaborator
Author
|
Consolidated into #4410. Closing to eliminate CI runner load. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
swing_sim.impactv_face_center = v_reference + omega x rand location-dependent curved-face normalsWhy
The former delivery path exposed useful scalar approximations but did not provide one typed 3D geometry contract or visually distinguish the tracked head datum from the face center and actual impact location. That made horizontally compound deliveries easy to misinterpret and allowed the planar loft-minus-AoA approximation to look exact.
Engineering boundaries
This PR treats the D-plane as geometry. It does not claim that geometry alone predicts launch direction, ball spin, gear effect, or aerodynamic curvature. Those remain downstream collision/contact/flight-model responsibilities. Positive-right/fade wording is explicitly limited to the current right-handed display convention.
This is a bounded stacked slice for #4182, #4183, and #4189. Those issues remain open for convention adapters, wider animation coverage, worked club/miss matrices, visual-regression/performance evidence, and protected review.
Validation
Stack
Base:
feat/4162-wedge-impact-visualization/ PR #4179.Refs #4180
Refs #4182
Refs #4183
Refs #4189