Skip to content

allow generate unmanaged type with VersionTolerant or circular serialization #451

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
uwx wants to merge 2 commits into
base: main
Choose a base branch
from
Open

allow generate unmanaged type with VersionTolerant or circular serialization #451

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
02eb3f1
allow generate unmanaged type with VersionTolerant or circular serial…
uwx Jun 12, 2026
4c9130e
chore: fix typescript test on Windows
uwx Jun 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/MemoryPack.Generator/MemoryPackGenerator.Emitter.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -193,7 +193,7 @@ string WithEscape(ISymbol symbol)

if (!xmlDocument)
{
if (type.IsUnmanagedType)
if (type.IsUnmanagedType && type.GenerateType is not GenerateType.VersionTolerant and not GenerateType.CircularReference)
{
sb.Append("GenerateType unmanaged ");
}
Expand All @@ -207,7 +207,7 @@ string WithEscape(ISymbol symbol)
else
{
sb.AppendLine("/// <remarks>");
if (type.IsUnmanagedType)
if (type.IsUnmanagedType && type.GenerateType is not GenerateType.VersionTolerant and not GenerateType.CircularReference)
{
sb.AppendLine("/// MemoryPack GenerateType: unmanaged<br/>");
}
Expand Down Expand Up @@ -269,7 +269,7 @@ public void Emit(StringBuilder writer, IGeneratorContext context)

var serializeBody = "";
var deserializeBody = "";
if (IsUnmanagedType)
if (IsUnmanagedType && GenerateType is not GenerateType.VersionTolerant and not GenerateType.CircularReference)
{
serializeBody = $$"""
writer.WriteUnmanaged(value);
Expand Down
8 changes: 1 addition & 7 deletions src/MemoryPack.Generator/MemoryPackGenerator.Parser.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -292,14 +292,8 @@ public bool Validate(TypeDeclarationSyntax syntax, IGeneratorContext context, bo
noError = false;
}

if (this.IsUnmanagedType)
if (this.IsUnmanagedType && GenerateType is not GenerateType.VersionTolerant and not GenerateType.CircularReference)
{
if (GenerateType is GenerateType.VersionTolerant)
{
context.ReportDiagnostic(Diagnostic.Create(DiagnosticDescriptors.VersionTolerantOnUnmanagedStruct, syntax.Identifier.GetLocation(), Symbol.Name));
noError = false;
}

var structLayoutFields = this.Symbol.GetAllMembers()
.OfType<IFieldSymbol>()
.Select(x =>
Expand Down
2 changes: 1 addition & 1 deletion tests/MemoryPack.Tests/SourceGeneratorTests/GeneratorDiagnosticsTest.TypeScript.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -206,7 +206,7 @@ public partial record FullName
""",
"FullName.ts");

generatedCode.Should().Contain(
generatedCode.Replace("\r\n", "\n").Should().Contain(
"""
export class FullName {
firstName: string;
Expand Down
8 changes: 5 additions & 3 deletions tests/MemoryPack.Tests/SourceGeneratorTests/GeneratorDiagnosticsTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -674,9 +674,9 @@ public Tester(int i1)
}

[Fact]
public void MEMPACK041_UnmanagedStructCannotBeVersionTolerant()
public void MEMPACK041_UnmanagedStructCanBeVersionTolerant()
{
Compile(41, """
var code = """
using MemoryPack;

[MemoryPackable(GenerateType.VersionTolerant)]
Expand All @@ -685,7 +685,9 @@ public partial struct Tester
[MemoryPackOrder(0)]
public int I1 { get; init; }
}
""");
""";
var (_, diagnostics) = CSharpGeneratorRunner.RunGenerator(code);
diagnostics.Length.Should().Be(0);
}

[Fact]
Expand Down