Repository navigation
List and forget the CyberWealth key like a personal fact - #114
Merged
Merged
Conversation
"What do you know about me?" now lists a held CyberWealth key by its last four characters in a DM (never mentioned in a channel), "what's my CyberWealth key?" answers the same way, and "forget my CyberWealth key" / "esqueça minha chave do cyberwealth" deletes that key alone. Showing reads only the stored last4 column (PersonalKeyStore.held), so the sealed key is never opened to answer; forget takes an optional service. New SHOW_KEY/FORGET_KEY fact actions keep the key out of FactKind and out of the "kind None means every fact" path. Docs, capabilities text and the add-cyberwealth-personal-keys change are updated.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A CyberWealth key saved in a DM now behaves like the other personal facts.
Chave do CyberWealth: …Nd4k/CyberWealth key: …Nd4k. A channel listing never looks the key up, so it can't mention it./forgetand Delete everything are unchanged.Implementation: new
SHOW_KEY/FORGET_KEYfact actions infact_intent(same precedence as the fact patterns);PersonalKeyStore.heldreads onlylast4/created_at, never the ciphertext, andforgettakes an optional service.AskService.attach_personal_keysis wired from the bot entrypoint.Tests: unit (PT/EN routing, masking, channel parity, SHOW built with a store whose
key_forraises, wiring throughbuild_bot), integration (heldunder an unopenable secrets key, per-service forget), e2e (listed masked in a DM and absent from a channel listing, NL forget keeps the email, replace). README, docs/operations.md, capabilities text (EN/PT) and the add-cyberwealth-personal-keys spec and tasks are updated.