Repository navigation
Keep provider API keys out of the logs - #113
Merged
Merged
Conversation
httpx logs every request URL at INFO, and Infura puts the API key in the URL path, so production logs carried the key on every chain read. The HTTP client loggers now start at WARNING, keeping their errors.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Production logs contained the Infura API key on every chain read, for example
HTTP Request: POST https://arbitrum-mainnet.infura.io/v3/<key> "HTTP/1.1 429 …". httpx logs each request URL at INFO, and Infura carries the key in the URL path.Fix
chatmemory.logging.configuresets the HTTP client loggers (httpx,httpx2,httpcore,httpcore2) to WARNING. Their errors are still logged; the per-request lines aren't. Every entrypoint goes through this setup.Tests
tests/unit/test_logging_secrets.pycovers two things:configure;Follow-up
The key already in the logs should be rotated; the production key was switched separately.