Repository navigation
Budget e2e time per scenario, not as a fixed suite total - #111
Merged
Merged
Conversation
The fixed 120 s total failed main after #110 (120.1 s, 185 passing scenarios, none over 3 s) and had already been raised from 60 s and 90 s for the same reason. A scenario over 10 s now fails the run by name, and the suite as a whole is capped at 1.5 s per scenario, so the cap grows with the suite but still catches a doubled average.
CI for #111 failed on test_live_btc_and_eth_carry_their_quote_time with CoinGecko answering HTTP 403 to the GitHub runner. The fixture probed only Frankfurter; the crypto test now pings CoinGecko first and skips on 403/429, the keyless tier refusing a shared IP or a burst.
CoinGecko answers /ping with 200 while refusing /simple/price with a 403 from CloudFront, so the probe let the test run into the refusal.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Main is red after #110. The
checksjob fails with every suite passing, because the end-to-end suite took 120.1 s against its fixed 120 s total budget. That's 185 scenarios, all passing, the slowest at 2.65 s. The same budget was already raised from 60 s and then 90 s for the same reason.Fix
over_budget()is a pure function with unit tests intests/unit/test_e2e_budget.py:docs/operations.mdand the e2e-harness OpenSpec tasks are updated.Checks
openspec validate --strictpass.