fix: nikon lens detection#1244
Open
lneugebauer wants to merge 4 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This change fixes a bug that made it impossible to automatically detect lenses from Nikon raw files for lens correction.
Closes #1123.
Type of Change
Changes Made
Screenshots/Videos
Testing
I've tested with my own Nikon raw files and was able to reproduce with sample raw files provided by photographylife.com for Canon, Nikon and Sony.
There is a remaining issue where the detection didn't work with the Panasonic file I downloaded. I didn't work on this as I've never worked with Panasonic raw files and don't know if this is representative.
Test Configuration:
Checklist
Additional Notes
AI Disclaimer:
Please state the involvement of AI in this PR: