Skip to content

fix: nikon lens detection#1244

Open
lneugebauer wants to merge 4 commits into
CyberTimon:mainfrom
lneugebauer:1123-fix-nikon-lens-detection
Open

fix: nikon lens detection#1244
lneugebauer wants to merge 4 commits into
CyberTimon:mainfrom
lneugebauer:1123-fix-nikon-lens-detection

Conversation

@lneugebauer
Copy link
Copy Markdown

@lneugebauer lneugebauer commented Jun 4, 2026

Description

This change fixes a bug that made it impossible to automatically detect lenses from Nikon raw files for lens correction.

Closes #1123.

Type of Change

  • Bug fix
  • New feature
  • Breaking change
  • Performance improvement
  • Code refactoring
  • Documentation update
  • UI/UX improvement
  • Build/CI or Dependency update

Changes Made

  • Prioritize the use of LensMake exif data over Make, as the latter one describes the body manufacturer.
  • Build a string that contains the lens name from the exif array. Search did break before with it being an array.

Screenshots/Videos

Testing

  • I have tested these changes locally and confirmed that they work as expected without issues

I've tested with my own Nikon raw files and was able to reproduce with sample raw files provided by photographylife.com for Canon, Nikon and Sony.
There is a remaining issue where the detection didn't work with the Panasonic file I downloaded. I didn't work on this as I've never worked with Panasonic raw files and don't know if this is representative.

Test Configuration:

  • OS: macOS Tahoe
  • Hardware: Apple M1 Max

Checklist

  • My code follows the project's code style
  • I haven't added unnecessary AI-generated code comments
  • My changes generate no new warnings or errors

Additional Notes

AI Disclaimer:

Please state the involvement of AI in this PR:

  • This PR is entirely AI-generated
  • This PR is AI-generated but guided by a human
  • This PR was handwritten with AI assistance (spell check, logic suggestions, error resolving)
  • This PR contains only blood, sweat, and coffee (AI-free)

@lneugebauer lneugebauer requested a review from CyberTimon as a code owner June 4, 2026 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

BUG: Lens correction - Nikon-F mount lenses not detected automatically

1 participant