Skip to content

verify() uses == instead of a constant-time comparison #23

Description

@CyberSunil

challenges/expert_vault.py compares the Expert Access Key with access_key.strip() == globals().get("_VALID_KEY"). app.py already does this
correctly for flags in /api/submit using hmac.compare_digest. The unlock path should match. Also worth storing a SHA-256 digest in _VALID_KEY rather than the key in cleartext.

File: challenges/expert_vault.py

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions