docs(paper): address second-round JOSS review comments - #136
Merged
Conversation
- Cite scikit-learn where the compatible API is mentioned; hyphenate "scikit-learn-compatible". - Cite the qte R package in both the Statement of Need and State of the Field, and add a bib entry for it. - Cite the Hillstrom and Oregon datasets in the Research Impact Statement and add a pointer to the online tutorials that reproduce the two paper figures. - Reword "manual implementations that lack statistical rigor" to focus on the missing inferential guarantees, and add a missing comma in the Software Design paragraph. - AI Usage Disclosure: state explicitly that the initial draft was written by the human authors without generative AI. - Update the Oka et al. (Econometric Reviews) and Yasui et al. (Japanese Economic Review) entries with definitive volume/issue/pages/year. - Fix co-author name for the Hirata et al. multi-task paper (Uto's given name is Shingo, not Shunsuke). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Update byambadalai2025efficientestimationdistributionaltreatment with the official ICML 2025 proceedings metadata (series ICML'25, article number 224, 24 pages, JMLR.org). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
…iance paper Replace the SSRN DOI with the NeurIPS proceedings DOI and add the pages, publisher, and series fields for the definitive citation. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses reviewer comments from openjournals/joss-reviews#11047 (comment).
Summary
scikit-learnwhere the "scikit-learn-compatible API" is mentioned (and hyphenate the compound adjective).qteR package (@qte) in both the Statement of Need and the State of the Field, and add a bib entry (Callaway, R package v2.0.0, 2026).@hillstrom2008and@finkelstein2012in the Research Impact Statement.@oka2025regressionto the definitive Econometric Reviews vol. 45(1), pp. 2–17, 2026.@yasui2026abemato the definitive Japanese Economic Review vol. 77(2), pp. 391–406.@hirata2025efficientscalableestimationdistributional: Uto is Shingo, not Shunsuke.https://cyberagentailab.github.io/python-dte-adjustment/tutorials/) that regenerate the two paper figures end-to-end.Test plan
🤖 Generated with Claude Code