win32 long path - #1147
Merged
Merged
win32 long path#1147
Conversation
Add XSUM_widenStringAsUncPath which converts UTF-8 path to absolute UNC path with "\\?\" prefix.
Note: So far it contains #pragma comment(lib) and pathcch.lib which only supports Windows 8+ or Windows Server 2012+. This issue must be fixed. This function supports 3 types of absolute path - Classic DOS path (C:\...) - Extended length path (\\?\...) - UNC path (\\...) Also relative path is properly converted to extended length path (\\?\...)
Now WIN32 CLI supports a file which ends with '.'. E.g. "my_file." test_trailing_period.bat tests it.
To keep compatibility, now CMakeFile.txt detects MSVC + Win10+ automatically. If user want to use MinGW, set XXHASH_WIN_TARGET_WIN10 to cmake. They set XXHSUM_WIN32_LONGPATH for C preprocessor.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This offers long path support, as well as support for complex characters, under Windows.
It builds upon #1061, that was started by @t-mat , and adds a few tests and minor complements and fixes to complete the diff.
closes #1060