Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Summary
Adding the new GetRace RPC means users can retrieve just the race they want by providing the Race ID. This will improve performance where only a single Race is required by reducing time spent filtering and reducing bytes sent between client and server. The GetRace RPC and GetRaceRequest message follow Google's AIP-131 Standard Methods: Get by using the HTTP GET verb for the request, using /races/{id} hierarchical format, and expecting a single parameter (id) to retrieve the resource. It also follows syntax-specific requirements such as the RPC name beginning with "Get", the RPC returning the resource type "Race" directly (not "RaceResponse" or similar), and naming the message "RaceRequest".
Example
Tests