Conversation
…StatusToRace/s methods to race repo. added timestamp util functions. added tests for all
…ure/race-status-field
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Summary
Races should have a Status field which is derived from their advertised_start_time property. A race in the past has status "CLOSED" and a race in the future has status "OPEN". As the Status is derived from the advertised_start_time, there are no DB changes to be made. When races are retrieved from the database, we iterate over the result and update the Status property of each race by comparing the current time to the advertised_start_time.
Example
{ "races":[ { "id":"1", "meetingId":"5", "name":"North Dakota foes", "number":"2", "visible":false, "advertisedStartTime":"2021-03-03T01:30:57Z", "status":"CLOSED" } ] }Tests