Conversation
…o filter message. updated applyFilter to add clause to sql string if visible is not null
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Summary
To filter by a Race's Visible property, we add the
optional bool visibleproperty to theListRacesRequestFilterprotobuf message. The property is optional because both true and false are valid values for the visible property and we can usenilto determine if the filter is set, then filter by visible = true or visible = false races.Example
curl -X "POST" "http://localhost:8000/v1/list-races"
-H 'Content-Type: application/json'
-d $'{
"filter": { "visible": true }
}'
Tests