Add support for Minecraft 26.2-snapshot-8 & Sulfur Caves#394
Open
linussztuka2011 wants to merge 16 commits into
Open
Add support for Minecraft 26.2-snapshot-8 & Sulfur Caves#394linussztuka2011 wants to merge 16 commits into
linussztuka2011 wants to merge 16 commits into
Conversation
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Adds support for the new sulfur_caves biome alongside updating the embedded cubiomes submodule, and adjusts the Qt project build configuration for the subproject.
Changes:
- Add localized display name for the
sulfur_cavesbiome. - Include
sulfur_cavesin the “underground biomes” warning mask. - Update
cubiomessubmodule revision and tweak.probuild paths for building cubiomes.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/util.cpp | Adds display-string mapping for the new biome ID. |
| src/conditiondialog.cpp | Treats sulfur_caves as an underground biome for warning logic. |
| cubiomes-viewer.pro | Changes cubiomes build path/make invocation to use relative paths. |
| cubiomes | Updates the cubiomes submodule commit. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
942
to
+946
| uint64_t underground = | ||
| (1ULL << (dripstone_caves-128)) | | ||
| (1ULL << (lush_caves-128)) | | ||
| (1ULL << (deep_dark-128)); | ||
| (1ULL << (deep_dark-128)) | | ||
| (1ULL << (sulfur_caves-128)); |
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
…g cubiomes sources inline under MSVC
test: add automated integration test for sulfur_caves and MC_26_2_S8
…qt (#10) * Fix Windows build to bundle Qt DLLs using windeployqt * CI: install qttools for Windows windeployqt --------- Co-authored-by: Gemini (AI) <gemini-bot@users.noreply.github.com> Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
* Initial plan * ci: fix ubuntu build by using distro Qt packages --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
…wn parameters (#13) Co-authored-by: Gemini (AI) <gemini-bot@users.noreply.github.com>
…es (#14) * Update cubiomes submodule to fix Woodland Mansion and Pale Garden spawn parameters * Fix sulfur_caves generation and filter out unassigned version gap ? entries in version selector --------- Co-authored-by: Gemini (AI) <gemini-bot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi! This PR adds support for the newest Minecraft snapshot and the new sulfur_caves biome.
Added MC_26_2_S8 to version constants.
Registered sulfur_caves (ID 187) and its display colors/translations.
Added it to the underground biome mask to ensure proper UI warnings when searching at surface heights (Y > 246).
Note on generation parameters: The exact tmin, tmax, hmin parameter limits for sulfur_caves in 26.2-snapshot-8 are currently estimated using standard cave depth parameters (dmin = 1000, dmax = 9500) similar to dripstone/lush caves, to ensure stable generation until the noise offsets are fully reverse-engineered.