Repository navigation
feat(macutil): build the app on Intel and Apple Silicon CI - #8
Merged
Merged
Conversation
Build osx-x64 on macos-13 and osx-arm64 on macos-14, then lipo on macos-14. scripts/check-version.sh fails when fsproj, Info.plist, and build scripts drift. Release.yml publishes those macOS artifacts instead of Linux-built Mach-O.
Drop unused YELLOW. Check publish and lipo exit codes with if !.
parsePrefValue and tweakJson use typ as the PrefValue type tag. crate-ci/typos@v1.34.0 treated that identifier as a misspelling.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Release.yml published osx-x64 and osx-arm64 from ubuntu-latest. Those Mach-O files were the only artifacts, and they were not built on Intel or Apple Silicon.
build_universal.shstill said 0.2.0 while the fsproj and Info.plist said 0.2.1.crate-ci/typos@v1.34.0 failed on the F# identifier
typinparsePrefValueandtweakJson. Those names are PrefValue type tags, not misspellings.Scope
.github/workflows/macos-app.ymladds jobs namedmacos-13andmacos-14. macos-13 publishes osx-x64. macos-14 publishes osx-arm64, lipos both intoMacUtil-Universal.app, and uploads zip artifacts..github/workflows/Release.ymlcalls that workflow and attaches the macOS zips. It no longer runsdotnet publishfor Mach-O on Ubuntu.MacUtilGUI/build_universal.shVERSIONis 0.2.1.scripts/check-version.shexits 1 when fsproj, Info.plist,build_universal.sh, anddeploy_macos.shdisagree._typos.tomlsets[default.extend-identifiers] typ = "typ".origin/mainat4b3201b. README from that commit remains.Does not edit
MainWindow.axaml. Does not deleteScriptService.fs.fsharp.ymlstill runs tests on ubuntu-latest.Tradeoffs
Native jobs on macos-13 and macos-14, with lipo on macos-14, instead of one runner publishing both RIDs. That matches GitHub's Intel and Apple Silicon labels. macos-14 waits on the x64 artifact.
The Release.yml publish job still runs on Ubuntu. It only uploads the macOS zips.
Blast Radius
CI and release packaging. GUI and engine code are unchanged. Unsigned
.appbundles still needxattr -crbefore Gatekeeper will launch them. No notarization in this PR.Verification
bash scripts/check-version.shfailed whilebuild_universal.shwas 0.2.0, then exited 0 at 0.2.1..github/workflows/macos-app.ymljob names aremacos-13andmacos-14.dotnet test MacUtilGUI.Tests --configuration ReleasePassed 14, Failed 0, Duration 60 ms.typos-cli 1.34.0exited 2 ontypwithout_typos.toml, then exited 0 with the ident file.check-typoson29caa7dconcluded success.