Skip to content

fix(macutil): per-tab status and trim-safe export - #20

Closed
Cryptokid92 wants to merge 20 commits into
mainfrom
mac-16-polish
Closed

Cryptokid92 wants to merge 20 commits into
mainfrom
mac-16-polish

Conversation

@Cryptokid92

Copy link
Copy Markdown
Owner

Why

Tweaks and Install shared one StatusText string, so Applied N leaked across tabs. Export used reflection JsonSerializer.Serialize on a string array, which fails when PublishTrimmed is true.

Scope

  • Each tab binds its own status property: TweaksStatus, InstallStatus, MaintenanceStatus, UpdatesStatus.
  • PresetService.exportIds writes the JSON array with Utf8JsonWriter.
  • Unused macos-terminal, macos-left-panel, and macos-right-panel styles are gone.
  • Tests: PerTabStatusDoesNotLeak, ExportTrimSafe, plus existing tab tests now assert the per-tab status fields.

Tradeoffs

StatusText is split instead of a shared footer. Export no longer uses reflection serialize, so trimmed publish stays trim-safe.

Blast Radius

ViewModel status properties, Tweaks/Install/Maintenance/Updates footers, preset export, and the matching tests. Opaque #1C1C1E and Name=MacUtil stay.

Verification

  • Remote mac-16-polish tree matches local 0e6669e blobs for the 11 changed files.
  • Review screenshot: /Users/test/.grok/docs/macutil-plan-media/mac-16-review.png

Do not merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant