Repository navigation
fix(macutil): per-tab status and trim-safe export - #20
Closed
Cryptokid92 wants to merge 20 commits into
Closed
Cryptokid92 wants to merge 20 commits into
Cryptokid92 wants to merge 20 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Tweaks and Install shared one
StatusTextstring, soApplied Nleaked across tabs. Export used reflectionJsonSerializer.Serializeon a string array, which fails whenPublishTrimmedis true.Scope
TweaksStatus,InstallStatus,MaintenanceStatus,UpdatesStatus.PresetService.exportIdswrites the JSON array withUtf8JsonWriter.macos-terminal,macos-left-panel, andmacos-right-panelstyles are gone.PerTabStatusDoesNotLeak,ExportTrimSafe, plus existing tab tests now assert the per-tab status fields.Tradeoffs
StatusTextis split instead of a shared footer. Export no longer uses reflection serialize, so trimmed publish stays trim-safe.Blast Radius
ViewModel status properties, Tweaks/Install/Maintenance/Updates footers, preset export, and the matching tests. Opaque
#1C1C1EandName=MacUtilstay.Verification
mac-16-polishtree matches local0e6669eblobs for the 11 changed files./Users/test/.grok/docs/macutil-plan-media/mac-16-review.pngDo not merge.