Repository navigation
fix(macutil): per-tab status and trim-safe export - #19
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Tweaks and Install shared one
StatusTextstring, soApplied Nleaked onto Install.PresetService.exportIdsused reflectionJsonSerializer.Serializeon a string array. That dies whenPublishTrimmed=true.Scope
macos-terminal,macos-left-panel, andmacos-right-panelstyles fromMacUtilGUI/App.axaml. They had no consumers.AppTabkeys four status strings onMainWindowViewModel. Tweaks, Install, Maintenance, and Updates each bind their own footer.exportIdswrites a JSON array of ids withUtf8JsonWriter. No reflectionSerializeof string arrays.ExportTrimSafe,PerTabStatusDoesNotLeak. Reflection serialize ofstring[]is off in the test project.#1C1C1E.Name=MacUtil.Program.fslast.Tradeoffs
Four footer bindings keep the current chrome. A single footer that rebinds on tab change would need selected-tab state.
Utf8JsonWriterover a C#JsonSerializerContextso the GUI project stays F# only.Blast Radius
GUI footers and
PresetService.exportIds(CLIexportuses the same function). Apply, Undo, Install, Uninstall, Maintenance, and Updates still write user-domain work only. No sudo. No/var/log. SIP stays on.Verification
dotnet test --filter ExportTrimSafepassed. Ids serialize to a JSON array.JsonSerializer.Serializeofstring[]throws.Utf8JsonWriterstill writes.dotnet test --filter PerTabStatusDoesNotLeakpassed. TweaksApplied 1 tweak(s).leaves Install empty.dotnet test MacUtilGUI.Tests --configuration Releasepassed, 37 tests.rg macos-terminal MacUtilGUI/App.axamlis empty.fantomas --checkon the CI file set passed./Users/test/.grok/docs/macutil-plan-media/mac-16-review.png. Tweaks footer showsNothing is selected.after empty Apply. Install status stays empty.Do not merge.