Repository navigation
feat(macutil): uninstall selected Homebrew apps - #18
Merged
Merged
Conversation
Catalog casks and formulas only. A missing package is success.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Install could add catalog Homebrew apps but could not take them off. Uninstall is the dual of install. It uses catalog casks and formulas only. A missing package is success.
Scope
BrewClient.uninstallinMacUtilGUI/Services/BrewClient.fsrunsbrew uninstall --caskorbrew uninstall --formulafromAppEntrytokens.StatusTexttoNothing is selected.brew listand updates checkboxes.UninstallMissingIsOk,EmptyUninstallWritesNothing,RefreshDetectChecksBox,UninstallUsesCaskToken.--zap,/Applicationsname match, Apple system app deletion.Tradeoffs
Uninstall skips brew when
brew listalready omits the package, same as install skip when the package is present. If list is stale, stderr that containsnot installedorNo such kegis still success.Blast Radius
Install footer and
BrewClientchange. Tweaks groups, Maintenance, and Updates stay. Opaque#1C1C1EandName=MacUtilstay. Only catalog cask and formula names reachbrew uninstall.Verification
dotnet test --filter UninstallMissingIsOkpassed.dotnet test --filter EmptyUninstallWritesNothingpassed.dotnet test --filter RefreshDetectChecksBoxpassed.dotnet test MacUtilGUI.Tests --configuration Releasepassed, 35 tests.fantomas --checkon the CI file set passed./Users/test/.grok/docs/macutil-plan-media/mac-15-review.pngwith Uninstall and Refresh visible on the Install tab.Do not merge.