Repository navigation
feat(macutil): group Tweaks by category - #17
Merged
Merged
Conversation
Tweaks tab groups Safe and Caution rows by Tweak.Category. Safe and Caution stay separate. Empty Apply writes nothing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Tweaks is two flat lists. Each tweak already has Category. Install already groups by category with expanders. Tweaks should reuse that shape inside Safe and Caution.
Scope
TweakGroupViewModelis a category name plus theTweakRowViewModelrows in that category.MainWindowViewModelfillsSafeTweakGroupsandCautionTweakGroupsfromTweak.Category. Empty groups are omitted.The Tweaks tab renders an expander per group in the current scroller. A header checkbox selects every row in that group. Caution stays a separate group of groups.
Standard still selects only Safe Finder and Dock ids. Install groups, Maintenance, and Updates stay. The window stays opaque
#1C1C1E. The name stays MacUtil.Program.fsstays last.Tradeoffs
Expanders start open so the list stays one scroll. Header
AllSelecteddoes not subscribe to later row clicks. A mixed group stays unchecked on the header until the header is used again.Search is absent on Tweaks. The catalog is 34 rows. Filter later if the list grows.
Blast Radius
GUI Tweaks tab only. Apply, Undo, Standard, and Minimal still walk
SafeTweaksandCautionTweaks. Empty Apply still writes nothing. Caution ids stay out of Standard. No sudo. No/var/log.Verification
dotnet test --filter TweakGroupsByCategorypassed. Safe groups are Finder, Dock, Keyboard, Screenshots, Privacy. Caution groups are Keyboard, Screenshots, Privacy.dotnet test MacUtilGUI.Tests --configuration Releasepassed. 31 tests, includingStandardSafeOnly./Users/test/.grok/docs/macutil-plan-media/mac-14-review.png.Do not merge this PR.