Repository navigation
feat(macutil): add Install tab and delete the script runner - #10
Merged
Merged
Conversation
The Install tab lists apps from config/applications.json. BrewClient.installed checks a box when brew already has the cask or formula. Search filters the list. Install with no selection writes nothing. Callers no longer use the script runner. Follow-up commits delete ScriptService.fs and the embedded tab_data scripts.
MainWindow lists catalog apps as checkboxes. Detect uses BrewClient.installed. Install uses BrewClient.install with no sudo. Program.fs stays last.
Replace the Applications script list with Install checkboxes and a search box. Keep window background #1C1C1E and the MacUtil title.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The Applications tab still ran embedded bash through ScriptService. Install should list
config/applications.jsonand detect with Homebrew. This PR makes that the GUI path and deletes the script runner.Scope
MacUtilGUI/ViewModels/AppRowViewModel.fsandMacUtilGUI.Tests/InstallTabTests.fs.MainWindowViewModellistscatalog.Apps, checks boxes withBrewClient.installed, and installs withBrewClient.install.MainWindow.axamlreplaces the Applications script list with Install checkboxes and a Search box.ScriptService.fs,ScriptInfo.fs,ScriptCategory.fs, Tomlyn,scripts/tabs.toml,tab_data.toml, and theapplications-setupandsystem-setupscripts.#1C1C1E. Title stays MacUtil. No sudo brew.Tradeoffs
Detect uses
BrewClientonly. It does not match names under/Applications. On this hostbrew list --caskdoes not include Visual Studio Code, so that box starts unchecked.Blast Radius
The Run Script button is gone. Homebrew install is the app path. Tweaks still detect, apply, and undo. User-domain defaults still never run as root.
Verification
dotnet test MacUtilGUI.Tests --configuration Releasepassed 19 tests, includingInstallDetectChecksBox,EmptyInstallWritesNothing,SearchFiltersList, and the Tweaks tab tests.rg ScriptService MacUtilGUIis empty.rg 'Run Script'andrg tab_dataare empty.Launch screenshot is at
/Users/test/.grok/docs/macutil-plan-media/mac-8-review.png. The Install tab lists catalog apps as checkboxes. Visual Studio Code is unchecked. The Tweaks tab remains.