Repository navigation
macOS HWAccel: Phases 1–4 (GL through docs/CI) - #1
Draft
CrymsonDynamo wants to merge 6 commits into
Draft
CrymsonDynamo wants to merge 6 commits into
CrymsonDynamo wants to merge 6 commits into
Conversation
Share one codebase for Linux and macOS: CMake APPLE/Linux branches (GL version defs, GL_SILENCE_DEPRECATION, Homebrew prefixes, DEB packaging guarded), platform helpers for GLFW hints / GLEW init / executable path, and universal GLSL 410 shaders + matching ImGui string. Co-authored-by: o50899145 <o50899145@gmail.com>
Unify layout/input in logical window space and scale GL viewport/scissor by content scale for Retina. Replace zenity call sites with portable-file-dialogs (Linux + macOS). Accept Control or Super for save/open accelerators. Co-authored-by: o50899145 <o50899145@gmail.com>
cursor
Bot
changed the title
One Exporter::write_mp4 path with platform HW encoder selected by CMake (h264_nvenc on Linux, h264_videotoolbox on Apple), then libx264 / generic H.264. Open failures fall through the chain. UI: "Prefer hardware encoder" instead of NVENC-only wording. Co-authored-by: o50899145 <o50899145@gmail.com>
cursor
Bot
changed the title
Document one-codebase Linux apt + macOS brew builds, OpenGL deprecation on Mac, and HW encode backends. Add optional RAMMB_MACOSX_BUNDLE + DragNDrop CPack, .app Resources shader lookup, and a GitHub Actions compile job for ubuntu + macos. Co-authored-by: o50899145 <o50899145@gmail.com>
cursor
Bot
changed the title
Upstream pfd still requires CMake < 3.5, which Homebrew CMake rejects. Populate the header only and point includes at the source dir. Also set Homebrew PKG_CONFIG_PATH on macOS CI. Co-authored-by: o50899145 <o50899145@gmail.com>
Use IMPORTED_TARGET + library dirs so Homebrew libav* paths reach the linker (was -lavcodec with no -L on macos-latest). Co-authored-by: o50899145 <o50899145@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Phases 1–4 of the Mac HWAccel plan in one shared codebase (Linux + macOS via CMake). Phase 5 (Metal) intentionally deferred.
Phase 1 — CMake + GL + shaders
OpenGL 4.5 (Linux) / 4.1+forward (macOS), GLEW, universal GLSL 410, portable exe path.
Phase 2 — Runtime
HiDPI content-scale viewport, portable-file-dialogs, Ctrl/Cmd accelerators.
Phase 3 — Encode
h264_nvenc(Linux) /h264_videotoolbox(macOS) →libx264; UI “Prefer hardware encoder”.Phase 4 — Packaging & docs
.app:-DRAMMB_MACOSX_BUNDLE=ON+ Resources shader lookup + DragNDrop CPack.github/workflows/build.yml—ubuntu-latest+macos-latestcompile matrixVerification
Plan: Project store
docs/mac-hwaccel-plan.md