feat(aws-privatelink): simplify lab config to TF_VAR env vars#317
Closed
luckb0x wants to merge 4 commits into
Closed
feat(aws-privatelink): simplify lab config to TF_VAR env vars#317luckb0x wants to merge 4 commits into
luckb0x wants to merge 4 commits into
Conversation
…tation Replace existing aws-privatelink contents with new modular Terraform implementation supporting per-VPC, shared-VPC, and TGW-based cross-region architectures for CrowdStrike PrivateLink connectivity.
…ifacts Delete old CloudFormation templates and Lambda zip bundles that are superseded by the new Terraform-based PrivateLink modules.
…st modules Delete the monolithic privatelink-stack module (~700 lines) that duplicated logic already present in endpoint-vpc and sensor-host. Rewrite example 01 (per-VPC) to compose the same two modules used by examples 02 and 03, proving the single-account case is just a simpler wiring of the same building blocks. Additional cleanup: - Remove all .tfvars references; inputs come exclusively via TF_VAR_ env vars - Add explicit random provider declaration to all root modules - Fix variable descriptions (s/Prefer exporting/Export/) - Update architecture doc to show env var exports instead of HCL snippets
…to-derived AZs All three labs now share a consistent variable interface: - Required: owner_email, falcon_client_id, falcon_client_secret, falcon_cloud - Optional: region, environment, instance_type, ami_id - Removed: name_prefix, availability_zones, vpc_cidr, subnet_cidrs AZs auto-derive from the region. VPC CIDRs are hardcoded in locals. Environment variable is used as the resource name prefix (default: dev). Adds PrivateLink readiness check in user_data to avoid 4-min sensor fallback timeout on first boot.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
falcon_cloudrequired, removesname_prefixin favor ofenvironmentas prefixConfiguration interface (all labs)
Required:
TF_VAR_owner_email,TF_VAR_falcon_client_id,TF_VAR_falcon_client_secret,TF_VAR_falcon_cloudOptional:
TF_VAR_region,TF_VAR_environment,TF_VAR_instance_type,TF_VAR_ami_idTest plan
terraform validatepasses on all 3 examples