feat: add symfony 8 support#160
Conversation
|
thanks, can you update the test suite to also use sf8 in the tests. in case we lose support for older versions that is fine as long as the current active versions are supported. |
…ts check to fix older versions tests
I added symfony 8. I also fixed the tests for older versions. Symfony also does it this way in their runtime: https://github.com/symfony/runtime/blob/8.1/SymfonyRuntime.php#L204 I also added php 8.4 and 8.5 to the ci. |
|
@NoUseFreak Sorry to bother, but do you have time to look at this again? |
|
@NoUseFreak Could to run the workflow again? This is the only bundle holding us back to upgrade to symfony 8.0. Thanks for your time! |
|
will this be merged? |
|
@NoUseFreak Tnx! |
In this PR I add symfony 8 support for the cron bundle. The tests are updated and all work.
In symfony/symfony@0fbcaa1 the add() method gets removed in favor of addCommand()
What I did: