Skip to content

feat: add symfony 8 support#160

Merged
NoUseFreak merged 3 commits into
Cron:masterfrom
eazyurk:symfony8-update
Jun 29, 2026
Merged

feat: add symfony 8 support#160
NoUseFreak merged 3 commits into
Cron:masterfrom
eazyurk:symfony8-update

Conversation

@eazyurk

@eazyurk eazyurk commented Jun 1, 2026

Copy link
Copy Markdown
Contributor

In this PR I add symfony 8 support for the cron bundle. The tests are updated and all work.

In symfony/symfony@0fbcaa1 the add() method gets removed in favor of addCommand()

What I did:

  • Updated the symfony dependency
  • Replaced removed add() method with addCommand()

@eazyurk eazyurk mentioned this pull request Jun 1, 2026
@NoUseFreak

Copy link
Copy Markdown
Contributor

thanks, can you update the test suite to also use sf8 in the tests. in case we lose support for older versions that is fine as long as the current active versions are supported.

@eazyurk

eazyurk commented Jun 4, 2026

Copy link
Copy Markdown
Contributor Author

thanks, can you update the test suite to also use sf8 in the tests. in case we lose support for older versions that is fine as long as the current active versions are supported.

I added symfony 8. I also fixed the tests for older versions. Symfony also does it this way in their runtime: https://github.com/symfony/runtime/blob/8.1/SymfonyRuntime.php#L204

I also added php 8.4 and 8.5 to the ci.

@eazyurk

eazyurk commented Jun 12, 2026

Copy link
Copy Markdown
Contributor Author

@NoUseFreak Sorry to bother, but do you have time to look at this again?

@EJTJ3

EJTJ3 commented Jun 18, 2026

Copy link
Copy Markdown

@NoUseFreak Could to run the workflow again? This is the only bundle holding us back to upgrade to symfony 8.0.

Thanks for your time!

@shtumi

shtumi commented Jun 29, 2026

Copy link
Copy Markdown

will this be merged?

@NoUseFreak NoUseFreak merged commit 63a8c24 into Cron:master Jun 29, 2026
@EJTJ3

EJTJ3 commented Jul 2, 2026

Copy link
Copy Markdown

@NoUseFreak Tnx!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants