Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The complete repaired pinned-edit scanner rereads every pinner at head, including files whose bytes its immutable-tree diff already proves unchanged. This opt-in package reuses those base bytes. On the fixed canonical replay it eliminates 123 head blob requests and 5,882,040 payload bytes, preserving the complete 154-row report and exit behavior.
Claim type: scoped implementation-preservation proof with exact finite comparison and observed work counts. Timing is inconclusive; no runtime speedup or new kappa is claimed. This contribution was produced by Nick Petalas.
The proof uses the original
--no-renamestree diff: a merge-base pinner absent from its modified/deleted/type-changed set has the same bytes at head. The scanner's search, classification, target multiplicities, ordering and default/strict policy are unchanged. The new implementation is frozen at this first verified reduction.Credit Armin Pourshafeie / apoursh, #6319, for the original scanner; ToikY, #6357, for the exact source-read repairs used here; and their retained source/integrity lineage. Their source-read correctness is a cited dependency, not this contribution's audit deliverable. The exact PR6357 scanner at
170867c0a8f92375dfc489dd090bad5daee7b090is exported with its original notices and SHA256, so no unmerged Git object is needed for replay.Evidence
de5ec2e7a6074068452f45b1a191b5c72832df4ato7c49fe32c55de02c2c873655c804b16e4c3fef0arequests 124 head pinner blobs, returning 19,620,947 payload bytes.After: it requests one changed pinner, returning 13,738,907 payload bytes. All 154 complete pin rows agree, including 153 advisory stale rows, one repinned row and zero frozen stale rows. Both base-loading phases are unchanged. These are returned payload bytes, not filesystem I/O or memory measurements.
BENCHMARK.jsonrecords every run and binds its source/output hashes.40591325403a9897ca95f642345742d17b1bd2a0. Each registered command is below five minutes locally.From the worktree root, with full Git history and the standard library:
Use an installed CPython 3.12 path elsewhere. The direct verifier generates
PASS_PINNED_EDIT_READ_REUSEwith actual request/byte counters and source/package hashes. SetTMPDIRto an external scratch directory as needed. The README gives both complete scanner commands and the optional benchmark command.Advance claim. Canonical main remained unchanged at submission. Live open PRs, claims, merged searches and main's README text were refreshed; sparse cached-note coverage was incomplete and is not a novelty certificate.
Limitations and unrun obligations
This is an opt-in tooling package. It changes no shared scanner, CI gate, frozen input or selected result. The equivalence proof assumes the predecessor's supported path/encoding contract and valid, stable Git objects. It does not preserve failures caused solely by a redundant read of a corrupt or concurrently removed object. There is no cross-scan cache.
The predecessor's broader source-reader admission and native Windows lifetime obligations remain separate. No supplier admission, selected cold replay, compiler/native/ownership/precision/tape/recovery proof, Lean or Docker check was run. All five selected framework assumptions remain. Independent human and formal proof-kernel review are unclaimed.
Open next questions
Can the tree-wide digest search avoid decompressing repeated objects while preserving binary/text treatment and every substring match? First specify a blob-ID deduplication algorithm, expand its matches back to every filename and compare one complete historical report. Those semantics are unresolved here; no further optimization was attempted.
Related open work
CI notes
Both hosted checks passed at
40591325403a9897ca95f642345742d17b1bd2a0in run 41537223436: plan in 4m36s and registered package replay in 2m8s. The completed checks were confirmed once; run metadata confirms the matching head, completed status and successful conclusion.The registered replay executes both normal and optimized commands. Local normal/optimized behavior checks, registered replay, source pins and committed-byte/source-history checks also passed. Hosted success certifies execution of these bounded checks. Independent human and formal proof-kernel review remain unclaimed.
Merge Danger
Door: two-way.
Blast Radius: package.
Only
research/pinned-edit-read-reuse/is added. The shared scanner and selected frontier are unchanged.