test(transactions): cover history route integration#494
Open
h1065153539-create wants to merge 1 commit into
Open
test(transactions): cover history route integration#494h1065153539-create wants to merge 1 commit into
h1065153539-create wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GET /api/transactions/historyintests/routes/transactions.test.ts.SettlementsRepository.findManyPaginated.trust:readAPI-key scope.Closes #472
Validation
npm test -- transactionspassed: 1 test file, 10 tests.git diff --check -- src/routes/transactions.ts src/schemas/transactions.ts tests/routes/transactions.test.tspassed.npm run test:coverage -- transactionsran the focused tests successfully, then exited non-zero because the repo applies global thresholds to allsrc/**/*.tsandsrc/sdk/**during a filtered run.coverage/coverage-final.json:src/routes/transactions.ts: 100% statements, 100% branches, 100% functions, 100% lines.src/schemas/transactions.ts: 100% statements, 90% branches, 100% functions, 100% lines.npm run lintis blocked before linting by missingsrc/observability/eslint-plugin-logger-schema.jsimported fromeslint.config.js.npm run buildis still blocked by existing repo-wide TypeScript errors, but notransactions-related errors remain after this change.