test(payouts): add route integration coverage#493
Open
h1065153539-create wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
POST /api/payoutsschemas/payout.jsso payouts tests do not depend on unrelated OpenAPI schema side effects from the barrel exportCloses #457
Validation
npm test -- payoutspassed: 2 files, 13 testsnpm run test:coverage -- payoutsexecuted the focused suite successfully, then failed only because the repo's global coverage thresholds are applied to allsrc/**/*.tsandsrc/sdk/**when running a subsetcoverage/coverage-final.jsonforsrc/routes/payouts.ts: statements 100%, functions 100%, branches 100%git diff --checkpassedExisting upstream failures observed
npm run lintcurrently fails before linting becauseeslint.config.jsimports missingsrc/observability/eslint-plugin-logger-schema.jswhile only the.tssource exists.npm run buildis currently blocked by broad pre-existing TypeScript errors outside this change, including duplicate config keys, missing generated gRPC modules,bond.tsOpenAPI type augmentation, SDK constructor type drift, and other unrelated files.Notes
POST /api/payouts; there is no separate status-transition endpoint to exercise not-found transitions. The new tests cover the route's available conflict path through idempotency key mismatch and duplicate transaction-hash upsert semantics.