test(currency): cover whitelist normalization invariants#492
Open
h1065153539-create wants to merge 1 commit into
Open
test(currency): cover whitelist normalization invariants#492h1065153539-create wants to merge 1 commit into
h1065153539-create wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #458
Summary
src/services/currency/whitelist.test.tswith deterministic Vitest coverage for add/remove, idempotent add, empty vs populated lookups, admin guard behavior, and malformed code rejectionnormalize_currency_codeset_currenciesatomic by validating all inputs before replacing the current whitelistVerification
npm test -- whitelistnpm exec -- vitest run src/services/currency/whitelist.test.ts --coverage --coverage.include=src/services/currency/whitelist.ts(100% statements/branches/functions/lines forwhitelist.ts)Also attempted:
npm run lintcurrently fails before linting becauseeslint.config.jsimports missingsrc/observability/eslint-plugin-logger-schema.jsnpm run buildcurrently fails on existing unrelated project-wide TypeScript errors outside the currency whitelist serviceSecurity
The whitelist now rejects malformed, non-ASCII, overlong, and look-alike currency codes instead of silently adding them to the allow-list security boundary.