Repository navigation
v1.6.6 — Visibility Parity: forest concealment (#153) - #154
Merged
Merged
Conversation
calcVis/forestVis were already a faithful oracle port, wired into rendering, but visFraction short-circuited to 1.0 unless hiddenMines was on and a fogState existed -- forest concealment is core, always-on oracle gameplay, unrelated to the separate Hidden Mines fog-of-war feature. Compounding it, only the host render path ever supplied a fogState at all, so a joined guest never got any concealment even when the host did. Fix: calcVis accepts fogState: FogState?, treating a missing one as "no fog contribution" while still applying the forest term and distance floor. visFraction's useForestTerm path (tank + walking builder, matching the oracle's own per-sprite-kind calcvis() choice) always calls calcVis now. Fixes host, solo, and join uniformly through the same call sites. Also softens the sea/river water textures (too bold/high-contrast per live feedback) -- halved each texture's color delta from its base fill. 148/148 Bolo 2026Tests, 956/956 SwiftPM tests green (known pre-existing timing/port-contention flakes, confirmed unrelated and pass in isolation). Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01XdDqxCXosBhuFQWVkuCzrz
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
calcVis/forestVis(forest concealment) were already a faithful oracle port and already wired into rendering, but gated behindhiddenMines/fogState, which forest concealment has nothing to do with in the oracle -- so it never fired by default, and never fired at all for a joined guest regardless of settings.calcVisnow acceptsfogState: FogState?; a missing one means "no fog contribution," not "skip forest concealment." Fixes host, solo, and join uniformly through the sharedvisFraction/calcVisrender call sites.Fifth
1.6.xtheme (man/tank/boat/sound + now visibility), milestone 27.Test plan
swift test-- 956/956 (known pre-existing timing/port-contention flakes, confirmed unrelated)xcodebuild test -scheme "Bolo 2026"-- 148/148calcVis-with-nil-fogStatedifferential unit testsfogState)🤖 Generated with Claude Code
https://claude.ai/code/session_01XdDqxCXosBhuFQWVkuCzrz