Conversation
HatemMn
reviewed
Mar 3, 2026
* test: use playwright to test UI * fix: rebase * fix: increase coverage * test: increase coverage * fix: test E2E * chore(nix): update ui pnpm deps hash * fix: ant dropdown * fix: pnpm hashes npm audit fix
Manuthor
requested changes
Mar 4, 2026
Bumps [actions/setup-node](https://github.com/actions/setup-node) from 4 to 6. - [Release notes](https://github.com/actions/setup-node/releases) - [Commits](actions/setup-node@v4...v6) --- updated-dependencies: - dependency-name: actions/setup-node dependency-version: '6' dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact) from 4 to 7. - [Release notes](https://github.com/actions/upload-artifact/releases) - [Commits](actions/upload-artifact@v4...v7) --- updated-dependencies: - dependency-name: actions/upload-artifact dependency-version: '7' dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* fix(ui): e2e tests * fix(ui): refactor e2e tests, fix esbuild audit, update README and nix hash - Replace raw UUID .match() patterns with extractUuid() helper - Replace 15_000 timeout literals with UI_READY_TIMEOUT constant - Move security overrides to pnpm.overrides to fix esbuild audit (GHSA-67mh-4wv8-2f99) - Regenerate pnpm-lock.yaml with esbuild >=0.25.10 for vite-plugin-theme - Update ui.pnpm.darwin.sha256 for new lockfile - Rewrite ui/README.md for Node 22.x / pnpm 9.x workflow * chore: update Nix expected hash * fix(ui): address issue #749 – routes, sitemap, workers, server docs - Add routes.ts: centralised E2E route map (fixes hardcoded path duplication) - Add sitemap.spec.ts: navigation smoke test across all application pages - Update certificates-flow.spec.ts to import CERT_ROUTES from routes.ts - Update azure-flow.spec.ts to import AZURE_ROUTES from routes.ts and use UI_READY_TIMEOUT instead of the magic literal 30_000 - Add comment in start_kms_server.rs explaining why SPA deep-link routes are registered (client-side React-Router navigation support) - Make playwright workers configurable via PLAYWRIGHT_WORKERS env variable (defaults to 1; set to higher value to run tests in parallel) * fix(ui): sitemap – use h1 locator for read-only pages (owned, obtained, CSE) sitemap.spec.ts was checking [data-testid="submit-btn"] on all pages, but three pages are read-only list/info views that render an h1 heading instead: • /ui/access-rights/owned (ObjectsOwnedList) • /ui/access-rights/obtained (AccessObtainedList) • /ui/google-cse (CseInfo) Add a locator field to the Route interface so individual routes can override the default submit-btn assertion. Mark the three read-only routes with locator: 'h1'. Fixes CI failures in runs 22688538790. * fix(ui): sitemap – avoid strict mode violation on multi-h1 pages Playwright's strict mode throws when a locator resolves to more than one element. The owned, obtained, and Google CSE pages have two h1 elements (one from the app layout, one from the page body), so locator('h1') fails. Use .first() to select the first match, which is unambiguous and sufficient for a smoke-navigation check.
Bumps [docker/login-action](https://github.com/docker/login-action) from 3 to 4. - [Release notes](https://github.com/docker/login-action/releases) - [Commits](docker/login-action@v3...v4) --- updated-dependencies: - dependency-name: docker/login-action dependency-version: '4' dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [docker/metadata-action](https://github.com/docker/metadata-action) from 5 to 6. - [Release notes](https://github.com/docker/metadata-action/releases) - [Commits](docker/metadata-action@v5...v6) --- updated-dependencies: - dependency-name: docker/metadata-action dependency-version: '6' dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [docker/setup-buildx-action](https://github.com/docker/setup-buildx-action) from 3 to 4. - [Release notes](https://github.com/docker/setup-buildx-action/releases) - [Commits](docker/setup-buildx-action@v3...v4) --- updated-dependencies: - dependency-name: docker/setup-buildx-action dependency-version: '4' dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.