Skip to content

feat: Multiple UI Fixes#738

Open
HatemMn wants to merge 7 commits intodevelopfrom
fix/sortable_ui_elements
Open

feat: Multiple UI Fixes#738
HatemMn wants to merge 7 commits intodevelopfrom
fix/sortable_ui_elements

Conversation

@HatemMn
Copy link
Contributor

@HatemMn HatemMn commented Feb 26, 2026

Summary

c53978b feature -> add prettier and format everything
28c641c feature -> sorting located keys / fixes #732
38285bd fix -> update hashes and fix stuff
a7b3e12 feature -> add filters to the locate page / fixes #734
da07fce feature -> add WASM error message -> #764

@charming-wicket-5502
Copy link
Contributor

Spliting formating and fonctional changes into different commits would greatly help the code review process.

@HatemMn
Copy link
Contributor Author

HatemMn commented Mar 2, 2026

Okay thanks for the notice, will do that way

@HatemMn HatemMn changed the title feat: add prettier, format everything and fix issue feat: add prettier, format everything and add sorting to the Locate tab Mar 2, 2026
@HatemMn HatemMn changed the title feat: add prettier, format everything and add sorting to the Locate tab feat: add sorting to the Locate tab, add prettier, format everything Mar 2, 2026
@HatemMn HatemMn force-pushed the fix/sortable_ui_elements branch from 8b27f76 to 4d29bb3 Compare March 2, 2026 18:49
Comment on lines +764 to +771
<Table<LocateObjectRow>
dataSource={objects || []}
rowKey="object_id"
pagination={{
pageSize: 10,
showSizeChanger: true,
pageSizeOptions: [10, 20, 50, 100],
}}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing much changed from the previous version but in a nushell this diff looks huge because instead of manual state calculus like

    const [currentPage, setCurrentPage] = useState<number>(1);
    const [pageSize, setPageSize] = useState<number>(10);

Now antd handles everything internally (result is the same)

Copy link
Contributor Author

@HatemMn HatemMn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Had to take out prettier of the CI because nix does not support it

This is still the relevant commit : 4d29bb3

@HatemMn HatemMn force-pushed the fix/sortable_ui_elements branch from 221f3c2 to 4d29bb3 Compare March 2, 2026 19:27
@HatemMn HatemMn self-assigned this Mar 2, 2026
@HatemMn HatemMn force-pushed the fix/sortable_ui_elements branch from 456eb6c to 333df8d Compare March 3, 2026 14:53
@HatemMn
Copy link
Contributor Author

HatemMn commented Mar 3, 2026

@copilot for a reason beyond my understanding my run of prettier deleted some attributes that might have importance like for example this diff :

        <Button type="primary" htmlType="submit" loading={isLoading}
                                className="w-full text-white font-medium" data-testid="submit-btn">
                        <Button type="primary" htmlType="submit" loading={isLoading} className="w-full text-white font-medium">

in src/AzureImportKek.tsx

There is a lot of formatted files ...

Open a PR where you REVERT any change that's NOT formatting and might be a prettier (or eslint) parasite (which is weird)

IGNORE edit src/Locate.tsx
IGNORE all files where only formatting is edited, and where non 'format' attributes are left intact

Copy link
Contributor

Copilot AI commented Mar 3, 2026

@HatemMn I've opened a new pull request, #753, to work on those changes. Once the pull request is ready, I'll request review from you.

@HatemMn HatemMn force-pushed the fix/sortable_ui_elements branch 2 times, most recently from 841b554 to 9772403 Compare March 5, 2026 17:20
@HatemMn HatemMn changed the title feat: add sorting to the Locate tab, add prettier, format everything feat: Multiple UI Fixes Mar 5, 2026
@HatemMn HatemMn linked an issue Mar 5, 2026 that may be closed by this pull request
HatemMn added 5 commits March 6, 2026 21:09
feat: fix format
ci:reabse stuff
also a line on the CI that makes it check formatting
feat: fix2
feat: fix3
feat: fix formatting mess
@HatemMn HatemMn force-pushed the fix/sortable_ui_elements branch from 54f8d49 to da07fce Compare March 6, 2026 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

3 participants