Conversation
|
Spliting formating and fonctional changes into different commits would greatly help the code review process. |
|
Okay thanks for the notice, will do that way |
8b27f76 to
4d29bb3
Compare
| <Table<LocateObjectRow> | ||
| dataSource={objects || []} | ||
| rowKey="object_id" | ||
| pagination={{ | ||
| pageSize: 10, | ||
| showSizeChanger: true, | ||
| pageSizeOptions: [10, 20, 50, 100], | ||
| }} |
There was a problem hiding this comment.
Nothing much changed from the previous version but in a nushell this diff looks huge because instead of manual state calculus like
const [currentPage, setCurrentPage] = useState<number>(1);
const [pageSize, setPageSize] = useState<number>(10);
Now antd handles everything internally (result is the same)
221f3c2 to
4d29bb3
Compare
456eb6c to
333df8d
Compare
|
@copilot for a reason beyond my understanding my run of prettier deleted some attributes that might have importance like for example this diff : in src/AzureImportKek.tsx There is a lot of formatted files ... Open a PR where you REVERT any change that's NOT formatting and might be a prettier (or eslint) parasite (which is weird) IGNORE edit src/Locate.tsx |
841b554 to
9772403
Compare
feat: fix format ci:reabse stuff
also a line on the CI that makes it check formatting
feat: fix2 feat: fix3 feat: fix formatting mess
54f8d49 to
da07fce
Compare
Summary
c53978b feature -> add prettier and format everything
28c641c feature -> sorting located keys / fixes #732
38285bd fix -> update hashes and fix stuff
a7b3e12 feature -> add filters to the locate page / fixes #734
da07fce feature -> add WASM error message -> #764