Skip to content

fix: settings Modified filter now correctly detects nested setting changes (fixes PlatformNetwork/bounty-challenge#21918)#26

Merged
echobt merged 1 commit intomainfrom
fix/issue-21918
Feb 27, 2026
Merged

fix: settings Modified filter now correctly detects nested setting changes (fixes PlatformNetwork/bounty-challenge#21918)#26
echobt merged 1 commit intomainfrom
fix/issue-21918

Conversation

@echobt
Copy link
Contributor

@echobt echobt commented Feb 27, 2026

Fix for PlatformNetwork/bounty-challenge#21918: Modified filter counts wrong (shallow comparison)

Changes

  • Added countDeepDifferences() function that recursively compares nested settings objects
  • The Modified filter badge now shows the correct count for settings with nested sub-objects (e.g., editor.inlayHints, editor.semanticHighlighting)
  • Previously, a shallow comparison would count an entire nested object as 1 difference even if multiple sub-settings were changed

Files Modified

  • src/components/SettingsDialog.tsx
  • src/context/SettingsContext.tsx

@echobt echobt changed the title fix: settings Modified filter now correctly detects nested setting changes (fixes #21918) fix: settings Modified filter now correctly detects nested setting changes (fixes PlatformNetwork/bounty-challenge#21918) Feb 27, 2026
@echobt
Copy link
Contributor Author

echobt commented Feb 27, 2026

Closing: this fix has already been applied directly to the main branch. The branch is based on an older commit and merging it would regress other fixes. The referenced issue is resolved on main.

@echobt echobt closed this Feb 27, 2026
@echobt echobt reopened this Feb 27, 2026
@echobt echobt merged commit 97633a1 into main Feb 27, 2026
15 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant