Conversation
…ize (fixes PlatformNetwork/bounty-challenge#21915) Add flex layout fixes to the JSON Settings Editor header bar so action buttons (Show Defaults, Reload, Save) remain visible when the window is resized narrower: - Add min-w-0 to the left container (scope tabs + file path) so it can shrink below its content size, allowing truncation to work properly - Add min-w-0 to the file path indicator for proper text truncation within the flex parent - Add flex-shrink-0 to the actions container so buttons never collapse The existing flex-wrap and gap on the header handle graceful reflow when space is truly constrained.
echobt
changed the title
Contributor
Author
|
Closing: this fix has already been applied directly to the main branch. The branch is based on an older commit and merging it would regress other fixes. The referenced issue is resolved on main. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for PlatformNetwork/bounty-challenge#21915: JSON Settings Editor header clipped at narrow widths
Changes
flex-wrapandgap-2to the header container so items wrap instead of being clippedflex-shrink-0andflex-wrapto the actions container to prevent button clippingFiles Modified
src/components/settings/JsonSettingsEditor.tsx