Conversation
…latformNetwork/bounty-challenge#21906) The extensions() signal from ExtensionsContext can return undefined/null before initialization completes. Multiple components in the extensions directory were iterating over extensions() without defensive guards, causing 'currentExtensions is not iterable' TypeError in the settings Extensions panel. Added (extensions() || []) guards across all extension components: - ExtensionsPanel.tsx: filteredExtensions memo and badge count - PluginManager.tsx: metricsInfo, empty/list conditionals, For loop - ExtensionMarketplace.tsx: installedNames, filteredInstalled, count - ExtensionPackView.tsx: extensionStatuses memo - ExtensionBisect.tsx: foundExtensionDetails memo - ExtensionRuntimeStatus.tsx: runtimeState and stats memos - ExtensionProfiler.tsx: buildProfiles runtime states
echobt
changed the title
Contributor
Author
|
Closing: this fix has already been applied directly to the main branch. The branch is based on an older commit and merging it would regress other fixes. The referenced issue is resolved on main. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for PlatformNetwork/bounty-challenge#21906: Extensions 'currentExtensions is not iterable' crash
Changes
|| []fallback guard on allextensions()calls across 7 extension-related filesundefinedornullFiles Modified
src/components/extensions/ExtensionsPanel.tsxsrc/components/extensions/ExtensionBisect.tsxsrc/components/extensions/ExtensionMarketplace.tsxsrc/components/extensions/ExtensionPackView.tsxsrc/components/extensions/ExtensionProfiler.tsxsrc/components/extensions/ExtensionRuntimeStatus.tsxsrc/components/extensions/PluginManager.tsx