Skip to content

fix: make settings dialog sidebar responsive at narrow widths (fixes PlatformNetwork/bounty-challenge#21903) #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
echobt merged 1 commit into from
Feb 27, 2026
+29 −5
Merged

fix: make settings dialog sidebar responsive at narrow widths (fixes PlatformNetwork/bounty-challenge#21903) #18

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions src/components/SettingsDialog.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -176,6 +176,7 @@ function SettingsTreeItem(props: {
display: "flex",
"align-items": "center",
width: "100%",
"min-width": "0",
gap: "6px",
padding: `4px 8px 4px ${8 + props.depth * 16}px`,
background: isActive() ? "var(--jb-list-active-bg, rgba(255,255,255,0.08))" : "transparent",
Expand Down Expand Up @@ -966,14 +967,14 @@ export function SettingsDialog(props: SettingsDialogProps) {
<Show when={!showJsonView()}>
<div style={{ display: "flex", height: "calc(90vh - 120px)", overflow: "hidden" }}>
{/* Sidebar */}
<div style={{
<div class="settings-sidebar" style={{
width: "256px",
"min-width": "200px",
"min-width": "120px",
"border-right": "1px solid var(--jb-border-default)",
"overflow-y": "auto",
"overflow-x": "auto",
"overflow-x": "hidden",
padding: "8px",
"flex-shrink": "0",
"flex-shrink": "1",
background: "var(--jb-panel)",
}}>
{/* Modified filter toggle */}
Expand Down Expand Up @@ -1002,7 +1003,7 @@ export function SettingsDialog(props: SettingsDialogProps) {
title={showModifiedOnly() ? "Show all settings" : "Show only modified settings"}
>
<Icon name="filter" style={{ width: "14px", height: "14px" }} />
<Text size="sm" style={{ flex: "1", "text-align": "left" }}>Modified</Text>
<Text size="sm" style={{ flex: "1", "text-align": "left", overflow: "hidden", "white-space": "nowrap", "text-overflow": "ellipsis" }}>Modified</Text>
<Show when={totalModifiedCount() > 0}>
<Badge
size="sm"
Expand Down
23 changes: 23 additions & 0 deletions src/styles/settings.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -860,3 +860,26 @@
gap: 8px;
}
}

/* Sidebar responsive: collapse to dropdown at very narrow widths */
@media (max-width: 500px) {
.settings-sidebar {
width: auto !important;
min-width: 0 !important;
max-width: 100% !important;
flex-shrink: 1 !important;
padding: 4px !important;
}

.settings-sidebar .settings-tab-button {
font-size: 12px;
padding-left: 4px !important;
padding-right: 4px !important;
}

.settings-sidebar .settings-tree-node span[style*="flex: 1"] {
overflow: hidden;
white-space: nowrap;
text-overflow: ellipsis;
}
}
Loading