Claude/project usability review ad4940 - #3
Merged
Conversation
usePagination clamps the current page at derive time, so search or filter changes that shrink the result set never strand you on a dead page. ListPagination shows a Showing X of Y summary with Prev/Next and hides itself for single-page lists. Data stays fully loaded, so search, status-pill counts, and filters remain instant over the whole set; only the rendered slice is paginated. Invoices select-all is now page-scoped, leaving selections on other pages intact for bulk actions. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
The invoice list Send action now posts every selected id to a new
POST /mail/send-invoices and the server loops - one round-trip instead
of one fetch per invoice, and SMTP pacing stays server-side. Recipients
are resolved per invoice from the client (contact_email then email), so
the client just sends ids and renders the returned {sent, failures}
summary. Extracted the shared send path into sendInvoiceById; the
single /send-invoice route now delegates to it. Six tests cover
validation, per-invoice failure reasons, and that the loop runs.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.