test: validate broker adapters against Docker services - #15
Conversation
|
Warning Review limit reached
Next review available in: 51 minutes You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (7)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary
Adds Docker-backed, real-broker round-trip tests for the existing Kafka, Redis Streams, and RabbitMQ adapter modules, and fixes the two Redis production defects exposed by that validation: an obsolete client import and the stream-blocking argument.
Files changed
redis_bus.py— replaces incompatibleaioredisuse with the already-declaredredis.asyncioclient, creates the client synchronously, uses the supportedblockargument forxread, and closes it withaclose().tests/integration/docker-compose.yml— isolated Kafka, Redis, and RabbitMQ services used only by integration tests; Kafka is configured for one-node consumer-group startup.tests/integration/test_broker_adapters.py— one@pytest.mark.integrationround trip per existing adapter.requirements-dev.txt— retains test-only Kafka/RabbitMQ clients and removes the incompatible legacyaioredispackage.pyproject.toml— registers theintegrationmarker and makes the default suite exclude it, preserving a Docker-free unit path..github/workflows/ci.yml— adds a dedicatedpytest -m integrationjob with Docker startup and always-on teardown.README.md— records the verified adapter-validation status.Brokers and verified test result
kafka_bus.pyredis_bus.pyrabbitmq_bus.pyValidation performed
pytest -m integrationselected all three adapter tests and passed: 3 passed, 16 deselected in 3.56s.Risks
Follow-up recommendations