Skip to content

Fix memory leak in EVM BIP32 child key derivation #58

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Corey-Code merged 2 commits into from
Feb 3, 2026
Merged

Fix memory leak in EVM BIP32 child key derivation #58

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f507f77
Initial plan
Copilot Feb 3, 2026
9e3b710
Secure pubKey cleanup in EVM deriveChild function
Copilot Feb 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion src/lib/crypto/evm.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,7 @@ function deriveChild(
let currentIndex = index;

const intermediates: Uint8Array[] = [];
let pubKey: Uint8Array | null = null;

try {
// Retry derivation with subsequent indices if we hit invalid values as per BIP32
Expand All @@ -65,7 +66,11 @@ function deriveChild(
data.set(indexBytes, 33);
} else {
// Normal derivation: public key || index
const pubKey = secp256k1.getPublicKey(parentKey, true);
// Clean up old pubKey if this is a retry
if (pubKey !== null) {
secureZero(pubKey);
}
pubKey = secp256k1.getPublicKey(parentKey, true);
data.set(pubKey, 0);
const indexBytes = new Uint8Array(4);
new DataView(indexBytes.buffer).setUint32(0, currentIndex, false);
Expand Down Expand Up @@ -106,6 +111,9 @@ function deriveChild(
throw new Error('Unable to derive valid child key after multiple attempts');
} finally {
// Zero out all intermediate data
if (pubKey !== null) {
secureZero(pubKey);
}
for (const arr of intermediates) {
if (typeof crypto !== 'undefined' && crypto.getRandomValues) {
crypto.getRandomValues(arr);
Expand Down