Skip to content

Simplify secureZero function in evm.ts to remove ineffective random overwrite #56

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Corey-Code merged 3 commits into from
Feb 3, 2026
Merged

Simplify secureZero function in evm.ts to remove ineffective random overwrite #56

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
71a81e9
Initial plan
Copilot Feb 3, 2026
ba26c3e
Simplify secureZero in evm.ts to only use fill(0)
Copilot Feb 3, 2026
eda9020
Update secureZero comment to be more accurate about memory guarantees
Copilot Feb 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions src/lib/crypto/evm.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,12 +116,9 @@ function deriveChild(
}

/**
* Securely zero out a Uint8Array to prevent sensitive data from lingering in memory
* Clear a Uint8Array to reduce the likelihood of sensitive data lingering in memory
*/
function secureZero(arr: Uint8Array): void {
if (typeof crypto !== 'undefined' && crypto.getRandomValues) {
crypto.getRandomValues(arr);
}
arr.fill(0);
}

Expand Down