Skip to content

50 self analysis remove remaining false positive and make warnings only output actionable#51

Merged
SizzleUnrlsd merged 26 commits intomainfrom
50-self-analysis-remove-remaining-false-positive-and-make---warnings-only-output-actionable
Feb 26, 2026
Merged

50 self analysis remove remaining false positive and make warnings only output actionable#51
SizzleUnrlsd merged 26 commits intomainfrom
50-self-analysis-remove-remaining-false-positive-and-make---warnings-only-output-actionable

Conversation

@SizzleUnrlsd
Copy link
Contributor

@SizzleUnrlsd SizzleUnrlsd commented Feb 26, 2026

Description

This PR improves self-analysis signal quality and warning triage UX.

Changes included:

  • AnalyzerApp human output now applies warning filtering first, then keeps only functions linked to remaining diagnostics in --warnings-only mode.
  • Removed redundant conditional return in stripIntCasts(...):
    • return Cur ? Cur : V; -> return Cur;
    • This eliminates the false positive duplicate-condition diagnostic.
  • Added regression fixture for --warnings-only function filtering.
  • Updated run_test.py checks to validate the new behavior and keep existing regression coverage stable.

Architecture rationale:

  • Filtering is implemented in the presentation/output layer (CLI rendering), not in core dataflow/analysis logic, to avoid changing analysis semantics and future detection behavior.

Validation:

  • cmake --build build --target stack_usage_analyzer -j4
  • ./run_test.py --jobs=4 passed (414/414)
  • Targeted self-analysis check confirms no warning remains on stripIntCasts(...).

@SizzleUnrlsd
feat(cli): filter human function listing in warnings-only mode
3bc2ed8
@SizzleUnrlsd
test(fixtures): add warnings-only function-listing fixture
69f3b0c
@SizzleUnrlsd
test(regression): extend warnings-only and self-analysis checks
400ab55
@SizzleUnrlsd
fix(analysis): reduce false positives in invalid base reconstruction
94b754e
@SizzleUnrlsd
refactor(escape): expose local-strategy helper in internal API
579c830
@SizzleUnrlsd
fix(escape): treat local strategy ownership as non-escaping
8964c27
@SizzleUnrlsd
feat(escape): add local strategy target resolution
9b26129
@SizzleUnrlsd
fix(escape): suppress false escapes for local strategy usage
94e4b1e
@SizzleUnrlsd
test(fixtures): add local strategy no-escape regression case
af0a1ce
@SizzleUnrlsd
feat(uninitialized): improve ctor and out-param initialization reasoning
ee6365b
@SizzleUnrlsd
test(fixtures): add default-member return initialization case
b6251b8
@SizzleUnrlsd
test(fixtures): add empty lambda capture initialization case
eebc7bc
@SizzleUnrlsd
test(fixtures): add lambda receiver initialization case
5b3b700
@SizzleUnrlsd
test(fixtures): add optional receiver index reproducer
bcf3038
@SizzleUnrlsd
test(fixtures): add cpp record never-initialized case
edce03a
@SizzleUnrlsd
test(fixtures): add trivial constructor initialization case
0a8430d
@SizzleUnrlsd
test(fixtures): add nested subobject projection no-diagnostic case
523d2ac
@SizzleUnrlsd
fix(report): stabilize function-level file fallback in JSON output
83046ed
@SizzleUnrlsd
docs(readme): clarify warnings-only behavior in human output
648c0a8
@SizzleUnrlsd
docs(contributing): add repository contribution guidelines
1945e97
@SizzleUnrlsd
docs(patch): record self-analysis findings and follow-up actions
bed1043
@SizzleUnrlsd SizzleUnrlsd self-assigned this Feb 26, 2026
@SizzleUnrlsd SizzleUnrlsd linked an issue Feb 26, 2026 that may be closed by this pull request
Self-analysis: remove remaining false positive and make --warnings-only output actionable #50
Closed
github-advanced-security[bot]
github-advanced-security bot found potential problems Feb 26, 2026
View reviewed changes
src/analysis/UninitializedVarAnalysis.cpp
static const llvm::DIType* getAllocaDebugDeclaredType(const llvm::AllocaInst& AI)
{
auto* nonConstAI = const_cast<llvm::AllocaInst*>(&AI);
for (llvm::DbgDeclareInst* ddi : llvm::findDbgDeclares(nonConstAI))

Check warning

Code scanning / coretrace-stack-analyzer

ResourceLifetime.IncompleteInterproc Warning

[ !!Warn ] inter-procedural resource analysis incomplete: handle 'ref.tmp' may be acquired by an unmodeled/external callee before release ↳ no matching resource model rule or cross-TU summary was found for at least one related call ↳ include callee definitions in inputs or extend --resource-model to improve precision
src/analysis/UninitializedVarAnalysis.cpp
return var->getType();
}

for (llvm::DbgVariableRecord* dvr : llvm::findDVRDeclares(nonConstAI))

Check warning

Code scanning / coretrace-stack-analyzer

ResourceLifetime.IncompleteInterproc Warning

[ !!Warn ] inter-procedural resource analysis incomplete: handle 'ref.tmp12' may be acquired by an unmodeled/external callee before release ↳ no matching resource model rule or cross-TU summary was found for at least one related call ↳ include callee definitions in inputs or extend --resource-model to improve precision
src/analysis/UninitializedVarAnalysis.cpp

llvm::SmallPtrSet<const llvm::Metadata*, 16> visitedTypes;
return !debugTypeHasDataMembers(declaredType, 0, visitedTypes);
}

Check warning

Code scanning / coretrace-stack-analyzer

ResourceLifetime.IncompleteInterproc Warning

[ !!Warn ] inter-procedural resource analysis incomplete: handle 'visitedTypes' may be acquired by an unmodeled/external callee before release ↳ no matching resource model rule or cross-TU summary was found for at least one related call ↳ include callee definitions in inputs or extend --resource-model to improve precision
src/analysis/UninitializedVarAnalysis.cpp
return true;
}
out.clear();
}

Check warning

Code scanning / coretrace-stack-analyzer

ResourceLifetime.IncompleteInterproc Warning

[ !!Warn ] inter-procedural resource analysis incomplete: handle 'visiting' may be acquired by an unmodeled/external callee before release ↳ no matching resource model rule or cross-TU summary was found for at least one related call ↳ include callee definitions in inputs or extend --resource-model to improve precision
src/analysis/InvalidBaseReconstruction.cpp
{
using namespace llvm;

if (!currentType || !sourceElementType || depth > 12)

Check notice

Code scanning / coretrace-stack-analyzer

None Note

[ !Info! ] recursive or mutually recursive function detected
src/analysis/StackPointerEscapeResolver.cpp
static void collectVTableEntries(const llvm::Constant* node,
std::vector<const llvm::Constant*>& out)
{
if (!node)

Check notice

Code scanning / coretrace-stack-analyzer

None Note

[ !Info! ] recursive or mutually recursive function detected
src/analysis/UninitializedVarAnalysis.cpp
debugTypeHasDataMembers(const llvm::DIType* type, unsigned depth,
llvm::SmallPtrSetImpl<const llvm::Metadata*>& visitedTypes)
{
if (!type || depth > 12)

Check notice

Code scanning / coretrace-stack-analyzer

None Note

[ !Info! ] recursive or mutually recursive function detected
src/analysis/UninitializedVarAnalysis.cpp
std::uint64_t baseOffset, unsigned depth,
RangeSet& out)
{
if (!ty || depth > 12)

Check notice

Code scanning / coretrace-stack-analyzer

None Note

[ !Info! ] recursive or mutually recursive function detected
src/analysis/UninitializedVarAnalysis.cpp
const llvm::DIType* type, std::uint64_t baseOffsetBits, unsigned depth,
llvm::SmallPtrSetImpl<const llvm::Metadata*>& visiting, RangeSet& out)
{
if (!type || depth > 16)

Check notice

Code scanning / coretrace-stack-analyzer

None Note

[ !Info! ] recursive or mutually recursive function detected
@SizzleUnrlsd SizzleUnrlsd merged commit 8800260 into main Feb 26, 2026
10 checks passed
@SizzleUnrlsd SizzleUnrlsd deleted the 50-self-analysis-remove-remaining-false-positive-and-make---warnings-only-output-actionable branch February 26, 2026 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@SizzleUnrlsd SizzleUnrlsd

Labels

FP

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Self-analysis: remove remaining false positive and make --warnings-only output actionable

1 participant

@SizzleUnrlsd