fix: resolve deploy workflow failures since May 12#7
Merged
Conversation
Two bugs introduced by the supply chain hardening commit (b870fa2): 1. deploy-demo and deploy-supabase fail when DEMO_DEPLOY_REPOSITORY / DEPLOY_REPOSITORY vars are not set (the CopilotKit fork has no repository variables configured). The production remote URL resolves to just 'https://github.com/' which is not a valid repo. Fix: add job-level 'if' guards to skip these jobs when the vars are empty. 2. deploy-supabase fails with ENOENT on dist/ because the download-artifact step was missing 'path: dist'. The upload step packages the dist directory contents, but without an explicit download path they extract to the workspace root instead of dist/.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes two bugs introduced by the supply chain hardening commit (b870fa2) that broke deploy-demo and deploy-supabase jobs on every push to main since May 12.
Bug 1 -- Missing repository variable guards: The
DEMO_DEPLOY_REPOSITORYandDEPLOY_REPOSITORYrepository variables are not configured in the CopilotKit fork. This caused the production remote URL to resolve tohttps://github.com/(no repo path), producingfatal: repository not found. Fixed by adding job-levelifguards that skip deploy-demo and deploy-supabase when those vars are empty.Bug 2 -- Missing artifact download path: The
download-artifactstep for supabase was missingpath: dist, so the build output extracted to the workspace root instead of thedist/directory. The subsequentgh-pagescommand then failed withENOENT: no such file or directory, stat 'dist'. Fixed by adding the missingpath: distparameter.Test plan